Skip to content

Kinwave vars #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 6, 2021
Merged

Kinwave vars #129

merged 5 commits into from
May 6, 2021

Conversation

verseve
Copy link
Contributor

@verseve verseve commented May 5, 2021

No description provided.

vers-w added 4 commits May 5, 2021 11:29
@vers-w
kinwave vars inwater and volume
1d9584f 
- add kinematic wave variables inwater (lateral inflow [m3 s-1]) and volume (volume of water in the kinematic wave [m3] ) to the SurfaceFlow struct, for the coupling between wflow and Delwaq.
- fixed snow and glacierstore from glacier model in SBM (variables were not updated)
@vers-w
wflow_hbv output glacier_hbv
6b59cec 
fixed isue with snow and glacierstore, variables were not updated in hbv, and typo (drysnow)
@vers-w
update of changelog
ba943b0
@vers-w
changelog
d50b7ae 
mark parameters (volume, inwater), SurfaceFlow struct as code
@verseve verseve requested a review from hboisgon May 5, 2021 10:08
@verseve verseve linked an issue May 5, 2021 that may be closed by this pull request
Add new variables to the SurfaceFlow struct #116
Closed
hboisgon
hboisgon approved these changes May 6, 2021
View reviewed changes
Copy link
Collaborator

@hboisgon hboisgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definition of the inwater and volume variables are correct and the resulting water balance error for surface water (land+river) are small enough.

@vers-w
tests
b2c36fd 
added some tests for added variables inwater and volume
@verseve verseve merged commit 09a213c into master May 6, 2021
@verseve verseve deleted the kinwave_vars branch May 6, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hboisgon hboisgon hboisgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new variables to the SurfaceFlow struct
3 participants
@verseve @hboisgon @vers-w