코드 리팩터링

my-garden-be/src/main/java/org/hyunggi/mygardenbe/dailyroutine/entity/DailyRoutineEntity.java

@@ -66,4 +66,8 @@ public void update(final DailyRoutine dailyRoutine) {
         this.routineType = dailyRoutine.getRoutineType();
         this.routineDescription = dailyRoutine.getRoutineDescription();
     }
+
+    public boolean isNotOwner(final Long memberId) {
+        return !this.memberId.equals(memberId);
+    }
 }

my-garden-be/src/main/java/org/hyunggi/mygardenbe/dailyroutine/service/DailyRoutineService.java

@@ -78,13 +78,13 @@ private DailyRoutineEntity getDailyRoutineEntity(final Long timeBlockId, final M
         final DailyRoutineEntity dailyRoutineEntity = dailyRoutineRepository.findById(timeBlockId)
                 .orElseThrow(() -> new EntityNotFoundException("해당하는 ID의 DailyRoutine이 존재하지 않습니다."));
 
-        if (!dailyRoutineEntity.getMemberId().equals(member.getId())) {
+        if (dailyRoutineEntity.isNotOwner(member.getId())) {
             throw new BusinessException("본인의 DailyRoutine만 수정 및 삭제할 수 있습니다.");
         }
 
         return dailyRoutineEntity;
     }
-
+    
     @Transactional
     public Long deleteDailyRoutine(final Long timeBlockId, final MemberEntity member) {
         final DailyRoutineEntity dailyRoutineEntity = getDailyRoutineEntity(timeBlockId, member);

my-garden-be/src/test/java/org/hyunggi/mygardenbe/dailyroutine/entity/DailyRoutineEntityTest.java

@@ -144,4 +144,23 @@ void update() {
         assertThat(dailyRoutineEntity.getRoutineDescription()).isEqualTo(newDailyRoutine.getRoutineDescription());
         assertThat(dailyRoutineEntity.getMemberId()).isEqualTo(memberId);
     }
+
+    @Test
+    @DisplayName("dailyRoutineEntity의 멤버 아이디와 비교하여 본인의 DailyRoutine인지 확인할 수 있다.")
+    void isNotOwner() {
+        //given
+        final Long memberId = 1L;
+        final DailyRoutine dailyRoutine = getDailyRoutine(
+                getRoutineTime(9, 10),
+                "SLEEP",
+                "낮잠"
+        );
+        final DailyRoutineEntity dailyRoutineEntity = DailyRoutineEntity.of(dailyRoutine, memberId);
+
+        //when
+        final boolean isNotOwner = dailyRoutineEntity.isNotOwner(2L);
+
+        //then
+        assertThat(isNotOwner).isTrue();
+    }
 }