Fixed API

- Remove population attribute from OSM if value is NULL
- Default method of `geocoder.ip` is now ipinfo instead of Maxmind
- When <blank> is entered in Maxmind, it will search your own IP address.

Author: DenisCarriere

geocoder/api.py

@@ -372,7 +372,7 @@ def ip(location, **kwargs):
     :param location: (optional) if left blank will return your
                                 current IP address's location.
     """
-    return get(location, provider='maxmind', **kwargs)
+    return get(location, provider='ipinfo', **kwargs)
 
 
 def canadapost(location, **kwargs):

geocoder/base.py

@@ -284,7 +284,8 @@ def osm(self):
             if self.postal:
                 osm['addr:postal'] = self.postal
             if hasattr(self, 'population'):
-                osm['population'] = self.population
+                if self.population:
+                    osm['population'] = self.population
         return osm
 
     @property

geocoder/canadapost.py

@@ -157,5 +157,5 @@ def unit(self):
         return self.parse.get('SubBuilding')
 
 if __name__ == '__main__':
-    g = Canadapost("4 2023 4th Ave W, Vancouver")
+    g = Canadapost("453 Booth Street, ON")
     g.debug()

geocoder/maxmind.py

@@ -21,8 +21,11 @@ class Maxmind(Base):
     provider = 'maxmind'
     method = 'geocode'
 
-    def __init__(self, location='me', **kwargs):
-        self.location = location
+    def __init__(self, location, **kwargs):
+        if location:
+            self.location = location
+        else:
+            self.location = 'me'
         self.headers = {
             'Referer': 'https://www.maxmind.com/en/geoip_demo',
             'Host': 'www.maxmind.com',
@@ -110,5 +113,5 @@ def metro_code(self):
         return self.parse['location'].get('metro_code')
 
 if __name__ == '__main__':
-    g = Maxmind('me')
+    g = Maxmind('8.8.8.8')
     g.debug()

geocoder/osm.py

@@ -323,5 +323,5 @@ def place_rank(self):
 
 
 if __name__ == '__main__':
-    g = Osm('1552 Payette dr, Ottawa ON')
-    g.debug()
+    g = Osm('New York City')
+    print(g.osm)