Skip to content

Commit

Permalink
Doc: CMake 3.22.0+
Browse files Browse the repository at this point in the history
  • Loading branch information
ax3l committed Sep 5, 2024
1 parent 7b8c6ed commit a87abab
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 6 deletions.
1 change: 1 addition & 0 deletions NEWS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Please transition to ADIOS2.
For reading legacy ADIOS1 BP3 files, either use an older version of openPMD-api or the BP3 backend in ADIOS2.
Note that ADIOS2 does not support compression in BP3 files.

CMake 3.22.0 is now the minimally supported version for CMake.
pybind11 2.12.0 is now the minimally supported version for Python support.


Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ Our manual shows full [read & write examples](https://openpmd-api.readthedocs.io
## Dependencies

Required:
* CMake 3.15.0+
* CMake 3.22.0+
* C++17 capable compiler, e.g., g++ 7+, clang 7+, MSVC 19.15+, icpc 19+, icpx

Shipped internally in `share/openPMD/thirdParty/`:
Expand Down
2 changes: 1 addition & 1 deletion docs/source/dev/dependencies.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ These are currently:
Required
--------

* CMake 3.15.0+
* CMake 3.22.0+
* C++17 capable compiler, e.g., g++ 7+, clang 7+, MSVC 19.15+, icpc 19+, icpx

Shipped internally
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
requires = [
"setuptools>=42",
"wheel",
"cmake>=3.15.0,<4.0.0",
"cmake>=3.22.0,<4.0.0",
"packaging>=23",
"pybind11>=2.12.0,<3.0.0"
]
Expand Down
6 changes: 3 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,16 @@ def run(self):
out = subprocess.check_output(['cmake', '--version'])
except OSError:
raise RuntimeError(
"CMake 3.15.0+ must be installed to build the following " +
"CMake 3.22.0+ must be installed to build the following " +
"extensions: " +
", ".join(e.name for e in self.extensions))

cmake_version = parse(re.search(
r'version\s*([\d.]+)',
out.decode()
).group(1))
if cmake_version < parse('3.15.0'):
raise RuntimeError("CMake >= 3.15.0 is required")
if cmake_version < parse('3.22.0'):
raise RuntimeError("CMake >= 3.22.0 is required")

for ext in self.extensions:
self.build_extension(ext)
Expand Down

0 comments on commit a87abab

Please sign in to comment.