Skip to content

Depth buffer injection improvements #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DethRaid opened this issue Apr 14, 2023 · 1 comment
Open

Depth buffer injection improvements #8

DethRaid opened this issue Apr 14, 2023 · 1 comment

Comments

@DethRaid
Copy link
Owner

Some things to improve the depth buffer injection:

  • Generate a mip chain for the normal target as well
  • Can we use FP16 when generating the depth buffer mip chain?
  • One pass to inject into all cascades. The VS reads the point's position and normal and passes it to the GS. The GS tests that position against each cascade, and emits a primitive for each cascade that passes. the FS adds the SH normal as usual
@DethRaid DethRaid converted this from a draft issue Apr 14, 2023
@DethRaid
Copy link
Owner Author

FP16 depth is fine?

One pass to inject cascades took my total time from like 4 ms to 3 ms. It's good, but it could be better. Using mip 1 of the mip chain got me more gains

My occupancy is trash. Nsight says I'm blocked on passing attributes from stage to stage. I've converted to fp16 but it didn't make a huge difference. The whole thing isn't that slow, but I feel like it should be better

@DethRaid DethRaid moved this from In Progress to Done in Light Propagation Volume Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant