Feature/ 후보 장소 조회 API 구현 #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hodomaroo
reviewed
Jun 2, 2025
| import com.ODG.ODG_back.domain.RecommendedMidpoint; | ||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| public interface RecommendedMidpointRepository extends JpaRepository<RecommendedMidpoint, Long> { | ||
| RecommendedMidpoint findByMeeting(Meeting meeting); |
There was a problem hiding this comment.
RecommendedMidPoint를 List로 가져오는걸로 기억하고있었는데, 해당 코드에서는 미팅별로 하나의 장소만 선정되는 것 같습니다!
There was a problem hiding this comment.
저번 정기회의에서 모임별 중간지점을 하나씩만 선정하라고 해서 일단 하나만 가져오는 걸로 구현해봤어요
| case PROJECT -> filterProjectPlaces(places); | ||
| }; | ||
| } | ||
| private List<PlaceResponseDto> filterSocialPlaces(List<Place> places) { |
There was a problem hiding this comment.
전체적으로 매우 깔끔한 것 같은데, Social / Project 선택 시 필터링되는 장소 유형 목록들을 별도로 관리하면 코드를 조금 더 깔끔하게 관리할 수 있지않을까 합니다
There was a problem hiding this comment.
제가 보기에도 좀 별로인 것 같아서 MeetingType에 PlaceCategory 매핑 추가해서 유형별 필터링이 가능하게 수정했습니다.
새로운 MeetingType이나 PlaceCategory 추가해도 enum만 수정하면 확장 가능할 듯 합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
내용
/meetings/{inviteCode}/places
inviteCode를 기반으로 해당 모임을 조회RecommendedMidpoint가져옴RecommendedMidpoint의Midpoint에 매핑된 장소 (Place) 리스트 조회 후 DTO로 변환참고
RecommendedMidpoint)만 사용자에게 제공한다는 점 반영했습니다.PlaceMapper이용해 DTO 변환했습니다.