Refactor how Shader Stage is provided #887
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d moves spec info out
# Conflicts: # src/nbl/asset/utils/CHLSLCompiler.cpp
We want to keep SShaderSpecInfo as POD
added 17 commits
June 9, 2025 14:33
include/nbl/asset/IAsset.h
Outdated
Comment on lines
178
to
180
| virtual core::unordered_set<const IAsset*> computeDependants() const = 0; | ||
|
|
||
| virtual core::unordered_set<IAsset*> computeDependants() = 0; |
There was a problem hiding this comment.
this should disappear
There was a problem hiding this comment.
and from all classes
Comment on lines
+184
to
+185
| //TODO(kevinyu): Temporary set this to true to make changes compile. Will revisit this later for each asset | ||
| return true; |
There was a problem hiding this comment.
remove and make pure virtual before merge
added 11 commits
June 14, 2025 15:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined #871 and #839