Build & pipeline updates, examples PCH remake, code clean-up #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e examples_tests submodule
…onoDeviceApplication.hpp to allow some headers to be used in examples PCH, update examples_tests submodule
…ts in IDE, update examples_tests
…a.yml, continue-on-error: true; TODO: we will use https://github.com/actions/github-script action to update github UI with this step to display its status
AnastaZIuk
commented
Jun 12, 2025
| @@ -41,7 +41,8 @@ class MonoDeviceApplication : public virtual MonoSystemMonoLoggerApplication | |||
| using namespace nbl::core; | |||
| using namespace nbl::video; | |||
| // TODO: specify version of the app | |||
| m_api = CVulkanConnection::create(smart_refctd_ptr(m_system),0,_NBL_APP_NAME_,smart_refctd_ptr(base_t::m_logger),getAPIFeaturesToEnable()); | |||
| // TODO: take APP NAME from executable metadata, DO NOT use defines in order to allow this to be part of examples PCH | |||
There was a problem hiding this comment.
no metadata needed actually as it can be updated later iirc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.