Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
e2xauthoring
andpackages
directories to improve path handling, refactor code, and enhance functionality. The most important changes include updating path handling to useos.path.realpath
, refactoring theTask
class, and adding a callback to theSetGitAuthorDialog
component.Path Handling Improvements:
e2xauthoring/models/pool.py
: Updated thepath
attribute in thePool
class to useos.path.realpath
for resolving the absolute path.e2xauthoring/models/task.py
: Updated thepath
attribute in theTask
class to useos.path.realpath
for resolving the absolute path.Refactoring:
e2xauthoring/models/task.py
: Refactored thecopy
method in theTask
class to use a new_rename_notebook
helper method for renaming notebooks.API Changes:
packages/api/src/api.js
: Modified therename
andcopy
methods in theAPI
object to change the parameter name fromold_name
toname
.Component Enhancements:
packages/app/src/components/alerts/GitAuthorNotSetAlert.jsx
: Added a newhandleAuthorSet
function to update the state when the Git author is set.packages/app/src/components/dialogs/SetGitAuthorDialog.jsx
: Added anonAuthorSet
callback to theSetGitAuthorDialog
component to notify when the Git author is set. [1] [2]