Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git and api calls #23

Merged
merged 9 commits into from
Feb 20, 2025
Merged

Fix git and api calls #23

merged 9 commits into from
Feb 20, 2025

Conversation

tmetzl
Copy link
Member

@tmetzl tmetzl commented Feb 20, 2025

This pull request includes several changes to the e2xauthoring and packages directories to improve path handling, refactor code, and enhance functionality. The most important changes include updating path handling to use os.path.realpath, refactoring the Task class, and adding a callback to the SetGitAuthorDialog component.

Path Handling Improvements:

Refactoring:

  • e2xauthoring/models/task.py: Refactored the copy method in the Task class to use a new _rename_notebook helper method for renaming notebooks.

API Changes:

  • packages/api/src/api.js: Modified the rename and copy methods in the API object to change the parameter name from old_name to name.

Component Enhancements:

@tmetzl tmetzl added the bug Something isn't working label Feb 20, 2025
@tmetzl tmetzl merged commit 603a642 into main Feb 20, 2025
4 checks passed
@tmetzl tmetzl deleted the fix_git_and_api_calls branch February 20, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant