Skip to content

Commit 9d0a0b3

Browse files
committed
Comments
1 parent 2e91877 commit 9d0a0b3

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

.github/workflows/PrAssignee.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,23 @@ jobs:
6161
}
6262
}).catch((error) => {
6363
// TODO: add comments here.
64+
//
65+
// So, I'm not sure if the error is being thrown by `@octokit/request.js` or
66+
// `@octokit/plugin-retry.js`. I suspect that the initial error is thrown by
67+
// `request.js`, and is subsequently propagated by `plugin-retry.js`.
68+
//
69+
// Anyway, the docs for `request.js` say the following:
70+
//
71+
// > If an error occurs, the promise is rejected with an `error` object
72+
//> containing 3 keys to help with debugging:
73+
// >
74+
// > - `error.status` The http response status code
75+
// > - `error.request` The request options such as `method`, `url` and `data`
76+
// > - `error.response` The http response object with `url`, `headers`, and `data`
77+
//
78+
// Source: https://github.com/octokit/request.js/blob/main/README.md#request
79+
//
80+
// So, inside this `.catch()`, we simply return that `error` object.
6481
6582
return error;
6683
});

0 commit comments

Comments
 (0)