Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad Fix function for sentence splitting((Draft for experimentation) #472

Draft
wants to merge 2 commits into
base: v25
Choose a base branch
from

Conversation

DrewThomasson
Copy link
Owner

No description provided.

@DrewThomasson
Copy link
Owner Author

Workflow is running right now

We shall see how this modification does

https://github.com/DrewThomasson/ebook2audiobook/actions/runs/13792236665

@DrewThomasson
Copy link
Owner Author

This other workflow is also running which made the Long_sentence test shorter, but a single giant paragraph with no punctuation for sentence splitting.

https://github.com/DrewThomasson/ebook2audiobook/actions/runs/13792248967

It's Just using a smaller test file that also produces the same error

So should be Faster in testing out the workflow

@DrewThomasson
Copy link
Owner Author

@ROBERT-MCDOWELL

I think I fixed it but well see later if those workflows show my modification to the get_sentences function worked or if you approve of it

@DrewThomasson
Copy link
Owner Author

DrewThomasson commented Mar 11, 2025

Ran on the Alice in wonderland test that broke the last one here
alice.mp4.zip
Not terrible,
alice.txt

Wait it keeps on saying pause.... did I accidentally add in the string "pause" into the sentence in function?

@DrewThomasson
Copy link
Owner Author

It keeps saying pause....

Is that because of this in the functions.py?

tts_manager.params['sentence'] = sentence.replace('.', '<pause>').replace(',', '<pause>')

@DrewThomasson DrewThomasson changed the title Fixed function for sentence splitting Bad Fix function for sentence splitting Mar 11, 2025
@DrewThomasson
Copy link
Owner Author

In other news this other attempt did not work tho lol

#473

@DrewThomasson
Copy link
Owner Author

Potential fix for custom models tho with the being spoken

If a custom xtts model

swap "." -> "|" instead of the current "." -> ""

This is just me talking to myself tho

The
"." -> ""

Works well for the default xtts model

But for custom fine-tuned xtts models

"." -> "|" works (Confirmed on the fine-tuned David attenborough model for english)

and also potentially

"." - > ";\n"

or

"." - > "\n"

could be fixes, But those may be language specific... Unknown at this exact moment

Findings derived from this source

coqui-ai/TTS#2952

@DrewThomasson DrewThomasson marked this pull request as draft March 11, 2025 17:40
@DrewThomasson DrewThomasson changed the title Bad Fix function for sentence splitting Bad Fix function for sentence splitting((Draft for experimentation) Mar 11, 2025
@ROBERT-MCDOWELL
Copy link
Collaborator

Potential fix for custom models tho with the being spoken

If a custom xtts model

swap "." -> "|" instead of the current "." -> ""

This is just me talking to myself tho

The "." -> ""

Works well for the default xtts model

But for custom fine-tuned xtts models

"." -> "|" works (Confirmed on the fine-tuned David attenborough model for english)

and also potentially

"." - > ";\n"

or

"." - > "\n"

could be fixes, But those may be language specific... Unknown at this exact moment

Findings derived from this source

coqui-ai/TTS#2952

I already explored this since long time... not a solution for all languages and can break at anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants