Skip to content

Expo - Can't build custom dev client for iOS #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nzhenry opened this issue Apr 28, 2022 · 6 comments
Open

Expo - Can't build custom dev client for iOS #92

nzhenry opened this issue Apr 28, 2022 · 6 comments

Comments

@nzhenry
Copy link

nzhenry commented Apr 28, 2022

When I run eas build --profile development --platform ios on an Expo project with react-native-kontaktio included as a dependency, it fails on the fastlane step.

Here's the relevant log output:

› Compiling react-native-kontaktio Pods/KontaktBeacons » KontaktBeacons.m

❌  (node_modules/react-native-kontaktio/ios/KontaktBeacons.m:157:46)

  155 |     if (dict[@"minor"] == nil) {
  156 |         if (dict[@"major"] == nil) {
> 157 |             return [self createBeaconRegion:[RCTConvert NSString:dict[@"identifier"]]
      |                                              ^ declaration of 'RCTConvert' must be imported from module 'React.RCTConvert' before it is required

Can anyone shed any light on this please? It'd be great if I could use this library in my app without having to eject from the Expo managed workflow.

@nzhenry
Copy link
Author

nzhenry commented Apr 29, 2022

I've created a sample project which will demonstrate the error if you run eas build --profile development --platform ios

https://github.com/nzhenry/expo-ibeacon-test

@yhanssens
Copy link

yhanssens commented Apr 29, 2022

I'm also getting this error with the bare workflow setup of expo.

@yhanssens
Copy link

@nzhenry I found a fork from someone who fixed this issue: https://github.com/joaojusto/react-native-kontaktio

@nzhenry
Copy link
Author

nzhenry commented Jun 3, 2022

@yhanssens Thank you! That fork works in managed workflow with a custom dev client.

@nzhenry
Copy link
Author

nzhenry commented Jun 3, 2022

@andrekovac @JonasWho ^^ An easy fix for the issue in Expo. Any chance you could publish a new version?

@andrekovac
Copy link
Contributor

@nzhenry I asked the creator of the fork which @yhanssens linked for more information about his additions (see this question in his commit

We are not using react-native-kontaktio with Expo (and a custom dev client for that matter). However, PRs are of course very welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants