Skip to content
This repository has been archived by the owner on Feb 23, 2025. It is now read-only.

Update dependencies #417

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Update dependencies #417

merged 2 commits into from
Mar 14, 2024

Conversation

josephdecock
Copy link
Contributor

  • Update to latest IdentityModel preview
  • Add dotnet core as a target framework: This avoids some dependency issues, since IdentityModel targets both netstandard and net6.0. In the IM netstandard build, we include the System.Text.Json dependency explicitly. In the IM net6.0 build, we don't, because that's built in. This would cause an issue if an application targeted net6.0 and depended on OidcClient. If OidcClient only targets netstandard, then when it depends on IM, we get the netstandard build of IM, and bring along the System.Text.Json dependency.

This avoids some dependency issues, since IdentityModel targets both netstandard and net6.0. In the IM netstandard build, we include the System.Text.Json dependency explicitly. In the IM net6.0 build, we don't, because that's built in. This would cause an issue if an application targeted net6.0 and depended on OidcClient. If OidcClient only targets netstandard, then when it depends on IM, we get the  netstandard build of IM, and bring along the System.Text.Json dependency.
@josephdecock josephdecock requested a review from brockallen March 13, 2024 20:59
@josephdecock josephdecock changed the title Update dependnecies Update dependencies Mar 13, 2024
@brockallen brockallen merged commit ba54f97 into main Mar 14, 2024
3 checks passed
@brockallen brockallen deleted the joe/update-deps branch March 14, 2024 02:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants