Skip to content

RibbonGroup: Remove timeout #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cursork opened this issue Mar 14, 2025 · 0 comments
Open

RibbonGroup: Remove timeout #384

cursork opened this issue Mar 14, 2025 · 0 comments

Comments

@cursork
Copy link
Contributor

cursork commented Mar 14, 2025

This is brittle and a bad experience: the intention is that the ribbon doesn't calculate heights and widths immediately, because it does not yet have all of the data it needs.

This was somewhat sufficient for creating a ribbon all in one go, but:

  • It requires setting a timeout guaranteed to be greater than the time to receive all ribbon WC and WS instructions.
  • Once eEX in Ribbons #335 and more are implemented, it will be trivial to break
  • It already breaks if you're working one line at a time from Dyalog - no one is creating new objects quicker than the timeout

Other Ribbon issues than 335 might also be dependent on this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant