Skip to content

fix: patch for engineResourcePath for es6 and requirejs #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Felix-Dynamsoft
Copy link
Collaborator

CoreModule.engineResourcePaths.rootDirectory = "https://cdn.jsdelivr.net/npm/"; shows DCE related error on es6 and requirejs sample.

This is a temporary patch to fix the issue.

Copy link

github-actions bot commented Oct 10, 2024

PR Preview Action v1.4.3
Preview removed because the pull request was closed.
2024-10-10 20:22 UTC

Copy link
Contributor

@eugene-dynamsoft eugene-dynamsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Felix-Dynamsoft Felix-Dynamsoft merged commit 98ccb80 into main Oct 10, 2024
1 check passed
@Felix-Dynamsoft Felix-Dynamsoft deleted the fix/engineResourcePath-2.4.2000 branch December 16, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants