-
Notifications
You must be signed in to change notification settings - Fork 144
Make FIPS image locally buildable #4832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
706e318
to
38df664
Compare
Co-authored-by: Marcell Sevcsik <31651557+0sewa0@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it, it works but wouldn't it make sense to:
- have a
make
target for it, likemake images/build/fips
or something- similar to
dynatrace-operator/hack/make/deploy/deploy.mk
Lines 8 to 9 in f5c6938
deploy/fips: @make IMAGE_URI="$(IMAGE_URI)"-fips $(@D)
- similar to
- As cross-compiling takes an AGE (1h), I don't see anyone actually using it like that. So I would make the default platfrom the same as the system when building FIPS locally
|
# Conflicts: # hack/make/images.mk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran OPERATOR_DEV_BUILD_PLATFORM="linux/arm64" make images/build/fips
worked
# Conflicts: # hack/make/images.mk
Description
resolves https://dt-rnd.atlassian.net/browse/DAQ-6756
Also this change is based on what we had before for CGO=1 builds.
Locally, you can build fips image via:
first time it will be slow, and then when podman will cache layer, we are good and quick.
How can this be tested?
build/deploy and run some standard tests, for example
test/e2e/standard
also you can exec to operator pod and check envs: