-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FourSeason run scripts with version information. #52
Conversation
Thanks @AaronDonahue! I've built the docs; the relevant changes are displayed at https://portal.nersc.gov/cfs/e3sm/forsyth/data_docs_52/html/SCREAMv0/DYAMOND2/simulation_data/index.html#original-runs-scripts and https://portal.nersc.gov/cfs/e3sm/forsyth/data_docs_52/html/SCREAMv1/FourSeasons/simulation_data/index.html#original-runs-scripts. @PeterCaldwell @crterai Please review how the changes actually look in the built docs linked (as opposed to reviewing the pull request). I'm personally not a fan of how the |
Thanks, @forsyth2. I agree that it's weird that the simulation data table seems to exist under the Original Runs Scripts heading rather than under Simulation Data. If that can be corrected with making Original Runs Scripts a sub-heading that'd be great. Also, I just noticed that it may be good to reword |
Thats a good suggestion Chris. I'll go ahead and make that change. |
@forsyth2 , do you know what would happen if we moved
to before the Original Run Scripts section? Would that move the link up? Alternatively, we could just put Original Run Scripts at the top or we could change the Any thoughts? |
https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#sections -- maybe try replacing the |
No matter what I try, I can't seem to get the formatting right. Anything that makes "Original Run Scripts" a subsection/heading/part/etc. forces the sidebar to show the subsections rather than the child pages. I tried I also tried to just make it bold, but then it doesn't stand out at all amongst the rest of the bold text. Changing the caption from "Contents" to "Simulation Data" just changes how it looks on the web page; it doesn't affect the sidebar. |
@AaronDonahue I think this is the best we can do: What do you think (of the sidebar, and of the page layout)? The full link is https://portal.nersc.gov/cfs/e3sm/forsyth/data_docs_52/html/SCREAMv0/DYAMOND2/simulation_data/index.html If that works, we just need @PeterCaldwell's approval to merge. |
@forsyth2 , this looks good to me. Thank you for taking the time to reformat the page. |
@AaronDonahue Great, thanks! @PeterCaldwell I will merge once you approve. The relevant changes are displayed at https://portal.nersc.gov/cfs/e3sm/forsyth/data_docs_52/html/SCREAMv0/DYAMOND2/simulation_data/index.html#original-runs-scripts and https://portal.nersc.gov/cfs/e3sm/forsyth/data_docs_52/html/SCREAMv1/FourSeasons/simulation_data/index.html#original-runs-scripts. |
Thanks all. It looks much better. It drives me batty that
I'd also love it if that first block of text fell under a subtitle of "Instructions" because as is, the reader isn't really sure what to expect from that text. But I can live without either of these changes. |
@PeterCaldwell My latest commit f46ff94 addresses your comments. The changes can be seen at:
@AaronDonahue is there a particular reason why the instructions section differs so much between these 2 pages? I should also note for the |
@forsyth2 , thanks for the fix and good catch on the HPSS. I believe that the SCREAMv0 page is a copy/paste from the E3SMv2 page which explains why they are different. I rewrote the SCREAMv1 page because I was unsure about using zstash for the FourSeasons data. @crterai can you take a look at the 2nd link and advise on what to put here? Is there an HPSS that is viable for the DYAMOND1 runs? |
@AaronDonahue This is a bit confusing. The v2 page actually more closely matches the SCREAM v1/Four Seasons page page than the SCREAM v0/DYAMOND2 page.
|
@forsyth2 looking into the file path, I don't think the SCREAM simulations are zstash archived. Files are archived as native model output, I think zstash won't apply in this case. |
@chengzhuzhang oh I see, thanks. |
No problem, we should revisit the pain points utilizing zstash for large files as those output from SCREAM and plan to accommodate. |
Hi @AaronDonahue and @forsyth2, So I looked at the v1 data link and I don't think zstash was used to archive either sets of simulations (v1 or v0). The file size of the scream output is so big so tar-ing up the data doesn't lead to better storage/ retrieval performance. So I think the v1 page can be written so that it removes the zstash reference and looks like the SCREAMv0 page. What do you think? |
@AaronDonahue @forsyth2 , I've updated the text so that it removes the reference to using zstash. |
3723e22
to
f719ae6
Compare
Thanks @crterai I built the docs again, so these links are now updated:
@AaronDonahue @PeterCaldwell Let me know if you want to take another look at these pages. They look good to me. We can merge today. |
@crterai approved, so I will merge. Thanks all! |
No description provided.