v3.002-dev-new #743

kenorb · 2024-04-24T19:24:50Z

No description provided.

Initial Exchange class

…test.cpp.

Indicators refactor (part 3)

…anager.test.cpp.

Indicator logic refactor

Improves support for C++ syntax

* origin/dev-cpp: Should fix all GCC warnings. Working compilation via GCC for TradeSignal.test.cpp and TradeSignalManager.test.cpp. State in the art of MQL/C++ compatibility. Making MQL code to compile in C++. Especially the TradeSignalManager.test.cpp. Trade: Fixes C++ compilation errors Adds TradeSignal and TradeSignalManager C++ compilation tests GHA: Compiles based on the file list Adds Compile workflow for CPP Adds StringSplit() as extern Adds .extern.h file for DateTime Refs: Uses PTR_ATTRIB syntax Integrates extern includes Adds Common and File defines Adds code page defines Adds .extern.h files Moves enums and structs from Std and MQL5 to appropriate files Moves Deal enums to Deal.enum.h

Should fix new issues with C++ compatibility.

* tag 'v2.011.1': Should fix problem "'array' - constant variable cannot be passed [GH-661] (#660)

* nseam/v3.000-dev: Refs EA31337-classes/EA31337-indicators-other#13, EA31337-classes/EA31337-indicators-other#15. WIP. TDI-RT-Clone and Heiken_Ashi_Smoothed indicators made to work in MT5.

* v3.001-dev-new: GHA: Compile: Fixes init-platform condition to compare with string, not boolean GHA: Compile: Fixes init-platform boolean condition Refs EA31337-classes/EA31337-indicators-other#13, EA31337-classes/EA31337-indicators-other#15. WIP. TDI-RT-Clone and Heiken_Ashi_Smoothed indicators made to work in MT5.

EA: Shows trade entry on error

…active pool (GH-705)

* v3.001-dev-new: Workaround for closing order conditions after orders are loaded from active pool (GH-705) Trade: TradeParams: Adds max_spread Order: Fixes the current volume value when data in orequest is missing Order: Refresh order after modification Trade: Disables filling modes for MQL4 EA: Fixes recent issue with error during trade request Account/AccountMt: Fixes zero division

* tag 'v3.000.2': Account/AccountMt: Fixes zero division GHA: Compile: Support for workflow calls GHA: Compile: Skips clean-up by default GHA: Fixes compilation workflows Trade: Disables filling modes for MQL4

* origin/v3.001-dev-new: Workaround for closing order conditions after orders are loaded from active pool (GH-705) Trade: TradeParams: Adds max_spread Order: Fixes the current volume value when data in orequest is missing Order: Refresh order after modification Trade: Disables filling modes for MQL4 Account/AccountMt: Fixes zero division Refs EA31337-classes/EA31337-indicators-other#13, EA31337-classes/EA31337-indicators-other#15. WIP. TDI-RT-Clone and Heiken_Ashi_Smoothed indicators made to work in MT5. GHA: Compile: Adds support for path input

coderabbitai · 2025-05-18T09:57:09Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate Unit Tests

Create PR with Unit Tests
Commit Unit Tests in branch v3.002-dev-new
Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

kenorb and others added 30 commits December 5, 2021 14:48

Account/SymbolInfo: Adds copy constructors

28bc1e9

Adds Exchange class and tests

3871dd8

Exchange: Adds Trade

3f09d09

SymbolInfo: Adds class constructor with symbol properties

92bb334

Exchange: Adds methods to add/remove account and symbol

78323e0

SymbolInfo: SymbolInfoEntry: Fixes struct copy constructor

a94b5c4

Merge pull request #621 from EA31337/dev-exchange

35af70c

Initial Exchange class

Moves Deal enums to Deal.enum.h

af586ee

Moves enums and structs from Std and MQL5 to appropriate files

f6fb496

Adds .extern.h files

19a1a84

Adds code page defines

79e542c

Adds Common and File defines

df9180d

Integrates extern includes

a70c358

Refs: Uses PTR_ATTRIB syntax

c3bb151

Adds .extern.h file for DateTime

fde05e4

Adds StringSplit() as extern

471e417

Adds Compile workflow for CPP

f2142ea

GHA: Compiles based on the file list

e17381a

Adds TradeSignal and TradeSignalManager C++ compilation tests

0b8be3b

Trade: Fixes C++ compilation errors

8826b3d

Making MQL code to compile in C++. Especially the TradeSignalManager.…

1dc8803

…test.cpp.

Merge pull request #634 from nseam/dev-indicator-refactor

57af000

Indicators refactor (part 3)

State in the art of MQL/C++ compatibility.

1c8a2ed

Working compilation via GCC for TradeSignal.test.cpp and TradeSignalM…

98f7b4e

…anager.test.cpp.

Merge pull request #636 from EA31337/dev-indicator-refactor

abf3b60

Indicator logic refactor

Should fix all GCC warnings.

8d1e4a5

Merge pull request #637 from nseam/dev-cpp

e76c4e5

Improves support for C++ syntax

Should fix new issues with C++ compatibility.

afb673c

Merge pull request #640 from nseam/dev-cpp

4355ade

Should fix new issues with C++ compatibility.

Merge tag 'v2.011.1' into v3.002-dev-new

483bd03

* tag 'v2.011.1': Should fix problem "'array' - constant variable cannot be passed [GH-661] (#660)

kenorb force-pushed the v3.001-dev-new branch from 55b5f54 to 20d2b0b Compare April 24, 2024 23:38

kenorb force-pushed the v3.002-dev-new branch from 0099bb6 to 902e830 Compare April 24, 2024 23:39

Merge remote-tracking branch 'nseam/v3.000-dev' into v3.001-dev-new

112b49e

* nseam/v3.000-dev: Refs EA31337-classes/EA31337-indicators-other#13, EA31337-classes/EA31337-indicators-other#15. WIP. TDI-RT-Clone and Heiken_Ashi_Smoothed indicators made to work in MT5.

kenorb force-pushed the v3.001-dev-new branch from 20d2b0b to 112b49e Compare April 24, 2024 23:42

kenorb force-pushed the v3.002-dev-new branch from 902e830 to 1b9a596 Compare April 24, 2024 23:42

GHA: Exchange: Adds path

69b6ae1

kenorb force-pushed the v3.002-dev-new branch from ece66a0 to 69b6ae1 Compare April 25, 2024 00:35

kenorb added 14 commits April 25, 2024 01:58

Account/AccountMt: Fixes zero division

92450aa

EA: Fixes recent issue with error during trade request

bf75e6d

EA: Shows trade entry on error

Trade: Disables filling modes for MQL4

0bfc38d

Order: Refresh order after modification

b4e2393

Order: Fixes the current volume value when data in orequest is missing

136ab98

Trade: TradeParams: Adds max_spread

c363605

Workaround for closing order conditions after orders are loaded from …

71089fc

…active pool (GH-705)

Trade: Disables filling modes for MQL4

460891f

GHA: Fixes compilation workflows

b14a877

GHA: Compile: Skips clean-up by default

0d00fcb

GHA: Compile: Support for workflow calls

31708c9

Account/AccountMt: Fixes zero division

35a2814

Merge tag 'v3.000.2' into v3.002-dev-new

01934b4

* tag 'v3.000.2': Account/AccountMt: Fixes zero division GHA: Compile: Support for workflow calls GHA: Compile: Skips clean-up by default GHA: Fixes compilation workflows Trade: Disables filling modes for MQL4

kenorb force-pushed the v3.001-dev-new branch 2 times, most recently from e4d95af to ae5d3df Compare April 27, 2024 15:42

kenorb added 4 commits April 27, 2024 16:49

IndicatorData: Adds Set()

03bf8a8

Strategy: Adds missing trend_threshold to constructor

043aeb3

Strategy: Improves logic for TrendStrength()

2c32123

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

v3.002-dev-new #743

v3.002-dev-new #743

Uh oh!

kenorb commented Apr 24, 2024

Uh oh!

coderabbitai bot commented May 18, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

v3.002-dev-new #743

Are you sure you want to change the base?

v3.002-dev-new #743

Uh oh!

Conversation

kenorb commented Apr 24, 2024

Uh oh!

coderabbitai bot commented May 18, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

CodeRabbit Configuration File (`.coderabbit.yaml`)