v3.009-dev-new #777

kenorb · 2024-10-10T21:17:20Z

No description provided.

* origin/v3.006-dev-fixme: (26 commits) More of C++/MT4/MT5 error fixes. Looks like C++/MT4/MT5 errors are fixed. Looks like C++/MT4 errors are fixed. Need some additional fixed for MT5. C++ and MQL fixes. Cleaned up Std.h regarding array/reference macros. Added Visual Studio file exclusions into .gitignore. C++ tests now compiles. WIP. Fixing C++ errors. One step further. WIP. Fixing C++ errors. Closer to the end. WIP. Fixing C++ errors. Closer to the end. WIP. Fixing C++ errors. Stuck on ValueStorage's macros. Adds PriceRange/tests/Makefile Moves global functions at the end for C++ compatibility A little step forward in fixing C++ compile errors. Another step in fixing C++ compile errors. Adds more tests for indicators Makefile: Improves syntax Adds more tests for indicators Adds CPP tests for EA, Log, Refs, Strategy and Trade Database: Code improvements and reformat Makefile: Fail when make subprocess also fail Indicators: Code reformats ...

Changes to Trade storing method (GH-687)

* commit 'c6e7145822937f1b4606c93cef73897b8062d17d': Removed temporary test code from test file. Testing Ref<X> serialization.

Platform: Adds dict of exchanges

Account: Adds ENUM_ACCOUNT_MARGIN_MODE for MQL4 Terminal: Fixes warning 30: macro redefinition Account: Defines ENUM_ACCOUNT_PARAM_INTEGER so it works for both MQL4 and MQL5

…was deleted despite being in use by SerializerNode.

Fixed SerializerJson which didn't clear pointer to "key"

* origin/v3.008-dev-new: CI: Removes Tick workflow as redundant CI: Runs tmate only on failure in debug mode CI: Do not run test if login is not specified [no-ci] C++ compatibility fixes.

Updated c++ compatibility table.

…added more checks for Indicator tree.

…Candle's OHLCVT value. Also moved ENUM_INDI_CANDLE_MODE enum into separate file.

…lasses into v3.009-dev-new--get-lowest-highest-checks

…t64.

…-checks Fixes for GetLowest(), GetHighest() for Indicator/IndicatorData with data export fixes

C++ compatibility fixes.

EMCC compatibility fixes.

coderabbitai · 2025-03-09T15:52:43Z

Warning

`.coderabbit.yaml` has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)

Validation error: Unrecognized key(s) in object: 'version'

⚙️ Configuration instructions

Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Fixed binary file writing.

…v-new * nseam/devcontainer-json: Added devcontainer.json file.

* origin/v3.009-dev-new: Fixed binary file writing.

nseam and others added 30 commits July 19, 2023 13:55

Testing Ref<X> serialization.

d019cc0

Removed temporary test code from test file.

6541e3f

Merge pull request #693 from nseam/v3.006-dev-fixme

c6e7145

Changes to Trade storing method (GH-687)

Merge commit 'c6e7145822937f1b4606c93cef73897b8062d17d' into v3.007-dev

fb9b41b

* commit 'c6e7145822937f1b4606c93cef73897b8062d17d': Removed temporary test code from test file. Testing Ref<X> serialization.

Just some minor fixes.

70a93ae

Exchange/Platform: Extends from Taskable

434c4d0

Platform: Adds dict of exchanges

Exchang.test: Fixes test

eaf64d7

Adds State struct

623acda

Exchange/Platform: Adds initial task methods

15360ee

DataParamEntry: Adds ToString() method

dba2b38

Serializer: Code reformats and improves debug messaging

fe4cd85

Account: Adds getters and setters for account params

130c7fa

Exchange/Platform: Adds getters and setters for params

5404886

Account: Adds ENUM_ACCOUNT_MARGIN_MODE for MQL4 Terminal: Fixes warning 30: macro redefinition Account: Defines ENUM_ACCOUNT_PARAM_INTEGER so it works for both MQL4 and MQL5

Exchange/Platform: Adds tests to init instances via JSON

48d2daa

EA: Improves data exporting code

f9c68ea

EA: Adds db export to test

b37b694

Fixed SerializerJson which didn't clear pointer to "key" and thus it …

3e03e95

…was deleted despite being in use by SerializerNode.

Merge pull request #698 from nseam/v3.007-dev-fixme

ad0c21f

Fixed SerializerJson which didn't clear pointer to "key"

Platform.test: Fixes JSON for valid one

ff2b6e6

Exchange: Passes accounts [no ci]

ec070dc

Added devcontainer.json file.

fef8faf

Merge remote-tracking branch 'origin/v3.007-dev' into v3.009-dev-new

6ecae7f

Adds missing const

6c796cf

AccountForex: Implements missing virtual methods

1c9f2b8

Runs tmat only in debug mode

a7228ea

Some fixes with const

3b755e9

Merge remote-tracking branch 'origin/v3.008-dev-new' into v3.009-dev-new

b9907e2

* origin/v3.008-dev-new: CI: Removes Tick workflow as redundant CI: Runs tmate only on failure in debug mode CI: Do not run test if login is not specified [no-ci] C++ compatibility fixes.

Fixes error: duplicate case value

b56cfa1

CONTRIBUTING: Adds int64 syntax

126e522

kenorb and others added 23 commits September 10, 2024 16:34

Merge pull request #770 from nseam/v3.009-dev--cpp-compatibility-table

5914168

Updated c++ compatibility table.

CONTRIBUTING: Adds footnotes

01a5be9

Updates .vscode/settings.json

4dd8b83

Moves Instances.h to Storage/

f6174a4

CI: Adds tests for Instances class

f54be8f

Adds Instances.test.cpp

b74eaeb

Moves Bar/Candle/Pattern to Platform/Chart/

64a2cc1

Removes Math.h as duplicate

7d7d396

Makefile: Adds support for MQL4/MQL5 compilation

3fc6cad

GetLowest() and GetHighest() fixes for Indicator/IndicatorData. Also …

d4ef76e

…added more checks for Indicator tree.

GetLowest() and GetHighest() now uses passed mode to retrieve proper …

aeb62f4

…Candle's OHLCVT value. Also moved ENUM_INDI_CANDLE_MODE enum into separate file.

Merge branch 'v3.009-dev-new' of https://github.com/EA31337/EA31337-c…

80e370f

…lasses into v3.009-dev-new--get-lowest-highest-checks

Tiny C++ compatibility fixes.

080e9fd

Fixing EATest and stack overflow in creating CSV Parser value from in…

8844e84

…t64.

Merge pull request #772 from nseam/v3.009-dev-new--get-lowest-highest…

feee6c2

…-checks Fixes for GetLowest(), GetHighest() for Indicator/IndicatorData with data export fixes

Web.test: Corrects include path

ca60d77

Improves Makefile

101a3da

C++ compatibility fixes.

b327268

Merge pull request #776 from nseam/v3.009-dev-new-cpp-fixes-2

542b3d7

C++ compatibility fixes.

EMCC compatibility fixes.

3b2fe9c

Merge pull request #779 from nseam/v3.009-dev-new--emmc-fixes

1a70529

EMCC compatibility fixes.

Fixed binary file writing.

1bd8ada

Updates devcontainer for additional extensions, installs rg

a931abe

kenorb added 6 commits March 9, 2025 15:54

Merge pull request #780 from nseam/dev--file-binary-write

5fcdcd4

Fixed binary file writing.

Merge remote-tracking branch 'nseam/devcontainer-json' into v3.009-de…

e17772a

…v-new * nseam/devcontainer-json: Added devcontainer.json file.

Installs Ansible to devcontainer

f33e4d4

Merge remote-tracking branch 'origin/v3.009-dev-new' into v3.009-dev-new

c8358a6

* origin/v3.009-dev-new: Fixed binary file writing.

Adds .coderabbit.yaml [no-ci]

4532a08

Trim trailing whitespaces [no-ci]

1349ec3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

v3.009-dev-new #777

v3.009-dev-new #777

Uh oh!

kenorb commented Oct 10, 2024

Uh oh!

coderabbitai bot commented Mar 9, 2025 •

edited

Loading

`.coderabbit.yaml` has a parsing error

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

v3.009-dev-new #777

Are you sure you want to change the base?

v3.009-dev-new #777

Uh oh!

Conversation

kenorb commented Oct 10, 2024

Uh oh!

coderabbitai bot commented Mar 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

.coderabbit.yaml has a parsing error

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Uh oh!

coderabbitai bot commented Mar 9, 2025 •

edited

Loading

`.coderabbit.yaml` has a parsing error