Use pyamrex in spacecraft charging example #4817
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
RemiLehe
changed the title
ax3l
reviewed
Sep 25, 2024
Examples/Physics_applications/spacecraft_charging/inputs_test_rz_spacecraft_charging_picmi.py
Outdated
Show resolved
Hide resolved
ax3l
reviewed
Jan 24, 2025
Examples/Physics_applications/spacecraft_charging/inputs_test_rz_spacecraft_charging_picmi.py
Outdated
Show resolved
Hide resolved
Until we add `__len__` via AMReX-Codes/pyamrex#407
ax3l
approved these changes
Jan 25, 2025
Use the one that does not rely on naming conventions but has named arguments. (The other one worked as well, but is deprecated.)
RemiLehe
commented
Jan 28, 2025
Examples/Physics_applications/spacecraft_charging/inputs_test_rz_spacecraft_charging_picmi.py
Outdated
Show resolved
Hide resolved
…rz_spacecraft_charging_picmi.py
ax3l
added a commit
to AMReX-Codes/pyamrex
that referenced
this pull request
Jan 29, 2025
We already have `.size` and we can iterate the `FabArray`, so we should support `len(mf)`, too. Seen in ECP-WarpX/WarpX#4817
ax3l
reviewed
Jan 29, 2025
| 2 * len(phi) | ||
| nr = phi.shape[0] | ||
| r = np.linspace(rmin, rmax, nr, endpoint=False) + (rmax - rmin) / ( | ||
| 2 * nr | ||
| ) # shift of the r points because the derivaties are calculated in the middle | ||
| face_z0 = ( | ||
| 2 * np.pi * 1.0 / dz * ((phi[:, 0] - phi[:, 1]) * r).sum() * dr |
There was a problem hiding this comment.
Looks correct/as before: the : is without ghost cells, () is with ghost cells.
https://pyamrex.readthedocs.io/en/latest/usage/compute.html
ax3l
reviewed
Jan 29, 2025
Comment on lines
+81
to
+84
| self.normalized_Er = warpx.multifab("Efield_fp", dir=self.dir_r, level=0).copy() | ||
| self.normalized_Er.mult(1 / q_v, 0) | ||
| self.normalized_Ez = warpx.multifab("Efield_fp", dir=self.dir_z, level=0).copy() | ||
| self.normalized_Ez.mult(1 / q_v, 0) |
There was a problem hiding this comment.
This is now perfectly parallel in MPI contexts, no global comms.
ax3l
reviewed
Jan 29, 2025
| phi = PhiFPWrapper(include_ghosts=True) | ||
| phi[...] += (q - q_v) * self.normalized_phi | ||
| Er = warpx.multifab("Efield_fp", dir=self.dir_r, level=0) | ||
| Er.saxpy(Er, (q - q_v), self.normalized_Er, 0, 0, 1, 0) |
There was a problem hiding this comment.
This is now perfectly parallel in MPI contexts, no global comms.
ax3l
reviewed
Jan 29, 2025
Comment on lines
+56
to
+61
| Er = warpx.multifab("Efield_fp", dir=self.dir_r, level=0) | ||
| Er.saxpy(Er, (q - q_v), self.normalized_Er, 0, 0, 1, 0) | ||
| Ez = warpx.multifab("Efield_fp", dir=self.dir_z, level=0) | ||
| Ez.saxpy(Ez, (q - q_v), self.normalized_Ez, 0, 0, 1, 0) | ||
| phi = warpx.multifab("phi_fp", level=0) | ||
| phi.saxpy(phi, (q - q_v), self.normalized_phi, 0, 0, 1, 0) |
There was a problem hiding this comment.
Note: #5613 will change saxpy
Suggested change
| Er = warpx.multifab("Efield_fp", dir=self.dir_r, level=0) | |
| Er.saxpy(Er, (q - q_v), self.normalized_Er, 0, 0, 1, 0) | |
| Ez = warpx.multifab("Efield_fp", dir=self.dir_z, level=0) | |
| Ez.saxpy(Ez, (q - q_v), self.normalized_Ez, 0, 0, 1, 0) | |
| phi = warpx.multifab("phi_fp", level=0) | |
| phi.saxpy(phi, (q - q_v), self.normalized_phi, 0, 0, 1, 0) | |
| Er = warpx.multifab("Efield_fp", dir=self.dir_r, level=0) | |
| Er.saxpy(q - q_v, self.normalized_Er, 0, 0, 1, 0) | |
| Ez = warpx.multifab("Efield_fp", dir=self.dir_z, level=0) | |
| Ez.saxpy(q - q_v, self.normalized_Ez, 0, 0, 1, 0) | |
| phi = warpx.multifab("phi_fp", level=0) | |
| phi.saxpy(q - q_v, self.normalized_phi, 0, 0, 1, 0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.