Keep calling all system my Home and spam "I'm not sure which system you're asking about"

[Tutul-]

Expected

Only call a system my Home when it match the system configured on EDDI

Observed

Each time I jump to a system, EDDI welcome me Home, and start spamming one or two "Im' not sure which system you're asking about" per system. The star description seem to work (most of the time?) and the "not mapped" work too so I'm not sure what script it's trying to execute. I did the update today and did reset all modified script (mostly settings)

Steps to reproduce

1. Update EDDI
2. Go to the "commander responder"
3. click on the field but let them empty
4. Jump to a system
5. Enjoy

Configuration

• Version [Please give full version numbers here, not just "latest" or "current"]
  • EDDI Version: v4.1.0
• Localization [if applicable]
  • EDDI's language: english
  • Voice: Microsoft Mark

My Investigation

Investigation Notes

Also it seem that setting a system didn't work either. I'm pretty sure the problem wasn't there until I clicked once on the input but kept it empty. Pretty sure the problem is a NULL check that also need to trim+is_empty check...
And a system wide scan also start that voice line

EDDI Logs

(will come in a comment because the verbose logs are too long)

[Tutul-]

eddi.log

[Tkael]

Ok, I see two issues here.

1. The reportsystem variable is apparently null. This is what is generating all of the "which system are you asking about" messages. I'm not entirely sure why the reportsystem variable is null but because you appear to be in the deep black and exploring new systems I imagine that SystemDetails() may be failing to retrieve the system information using the system name as a reference value (it's a slower and less efficient lookup to retrieve a system using its system name than using its unique numeric system address). The best solution might be to revise the SystemDetails() function to accept numeric system address values and use that for more efficient lookups. 🤔

2. If reportsystem and homesystem are both null then that triggers the "welcome home" message erroneously. We can modify the Jumped script to make sure the code only triggers when homesystem.name isn't null.

{if len(homesystem.name) > 0: 
    {if reportsystem.name = homesystem.name:
        Welcome home, {F("Honorific")}
    |else:
        {set ReportDistanceFromHome() to:
            {if reportsystem.distancefromhome:
                {return cat(
                    OneOf("You are", "Current location is", "You are now"), " ",
	                Humanise(reportsystem.distancefromhome), " lightyears from ",
    	            OneOf("home", P(homesystem.name, 'starsystem')), "."
    	        )}
    	    |elif carrier.currentStarSystem:
                {set toSystem to SystemDetails(carrier.currentStarSystem)}
	            {set dist to round(Distance(system.x, system.y, system.z, toSystem.x, toSystem.y, toSystem.z))}
                {return cat(
                    OneOf("You are", "Current location is", "You are now"), " ",
	                Humanise(dist), " lightyears from ",
	                OneOf("home", carrier.name), "."
	            )}
	        }
        } 
        {Occasionally(7, ReportDistanceFromHome())}
    }
}

[Tutul-]

I've been exploring new system for about a month now. The previous version of EDDI didn't failed before so I assume the SystemDetail might be new or modified since?

Btw my homesystem is unset. Did try to set it to one in the bubble but the selection didn't worked and the setting was discarded when I restarted EDDI.

Because I use a TTS profile, with some script with customized settings, I might have some leftover from before the update but I did reset the script before re-configure them. This the interface show also 2-3 script where the reset button is replaced by delete? Should I reset the profile and reconfigure all from scratch?

[jngreene]

I'm in the black exploring and have seen similar. reset my home system and station cleared the home problem, but the systems still keep coming back 'I'm not sure what system you're talking about'. This only began when EDDI updated from 4.0.4 to 4.1.0