Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pledged flag and notes on how to set #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

spansh
Copy link
Contributor

@spansh spansh commented Dec 3, 2024

No description provided.

Copy link
Contributor

@jixxed jixxed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -58,6 +58,10 @@
"type" : "boolean",
"description" : "Whether the sending Cmdr has an Odyssey expansion."
},
"pledged": {
"type" : "boolean",
"description" : "Whether the sending Cmdr is pledged to a superpower."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Whether the sending Cmdr is pledged to a Power" would be more accurate here.

@bgol
Copy link
Contributor

bgol commented Mar 5, 2025

I guess this is not needed anymore, from Trailblazers Update 1 - Thursday 6th March 2025

We are releasing Trailblazers Update 1 on Thursday March 6th. This update will address a number of reported issues.
Journal Additions: The following Journal entries are now logged:

  • The powerplay data in the event "Location" and "FSDJump" supplied regardlesss of if the Commander is pledged to a power or not.

@Tkael
Copy link
Member

Tkael commented Mar 7, 2025

Or won't be, once those changes actually are merged. ;-)

@bgol
Copy link
Contributor

bgol commented Mar 7, 2025

Yeah, one should always wait on the actual release before posting / changing programs. I implemended it and had many system with oscillating powerplay data. Now I know better.

@robbyxp1
Copy link
Contributor

On hold probably going to be deleted, lets see what those Frontier people do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants