Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling on site doesn't always disable all request modification in MV3 #3055

Open
ghostwords opened this issue Feb 7, 2025 · 0 comments
Open
Labels
bug Chrome MV3 Manifest V3-specific issue

Comments

@ghostwords
Copy link
Member

ghostwords commented Feb 7, 2025

It looks like that in order to disable Privacy Badger on a site in MV3, "allowAllRequests" rules are not enough, and we should also make session "allow" rules for requests with the disabled site domain as the initiator. Otherwise, we will continue to block service worker requests associated with the disabled sites.

These "allow" rules should be scoped to to tab IDs with tabs.TAB_ID_NONE, to avoid allowing requests from the disabled site initiator when the disabled site initiator is in a frame.

These rules have to be session rules because tab ID scoping isn't supported in dynamic rules.

w3c/webextensions#737 (comment)

https://github.com/uBlockOrigin/uBOL-home/blob/main/chromium/js/ruleset-manager.js#L519-L536

@ghostwords ghostwords added Chrome MV3 Manifest V3-specific issue bug labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Chrome MV3 Manifest V3-specific issue
Projects
None yet
Development

No branches or pull requests

1 participant