fix: Allow use of ${workspaceFolder} in dotPath setting
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @makisukurisu, thanks for your contribution, I have implemented a more generalized version to support variable substitution in #76, could you verify whether it satisfies your needs? |
|
@EFanZh, yes, it works as expected, thank you very much! I'll close this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the preview can only be opened when a file is selected, I assume that we can fetch
workspaceFolderbased on the opened file, and thus - use the most "correct" path variable.I tested the changes locally on my Windows machine, and the appropriate path was used in single-workspace case.
Related to issue #74