Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation Support #37

Open
mobedoor opened this issue Aug 11, 2023 · 2 comments
Open

Annotation Support #37

mobedoor opened this issue Aug 11, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@mobedoor
Copy link

Since Copilot already supports webclipping, I'd like to make a feature request. Could you extend it to be more of a page clipper such that all annotations made on a certain page are saved under one Block eg
for url https://www.usatoday.com/story/tech/news/2023/08/09/google-will-begin-deleting-inactive-accounts-in-december/70560101007/

#[[Clip]] Google will begin deleting inactive accounts in December 2023

  • Annotation 1 from page
  • Annotation 2 from page
  • Annotation 3 and so on

Bonus features would be to

  1. Add a floating highlight button
  2. Highlighting the clipped text a certain color upon clipping.
  3. Re-highlight the clipped sections upon revisiting the page.
@EINDEX EINDEX self-assigned this Aug 29, 2023
@EINDEX EINDEX added the enhancement New feature or request label Aug 29, 2023
@EINDEX
Copy link
Owner

EINDEX commented Aug 31, 2023

Thanks for your suggestion.

I will think about how to archive this.


Here is response for 3 bouns features.

For the first feature:
we have an option to enable floating botton currently, but some people think this is annoying so the default toggle is disabled.

For second:
I want to do this after the third feature is working, otherwise, the experience will not good as the user's expectation.

For the third feature:
I want to archive this too, recently I found there is an API that may access logseq plugin storage.
But not having time to test it yet.

https://github.com/logseq/logseq/blob/7de92849dd8ab98f3feb220b51206f55d32a8125/src/main/logseq/api.cljs#L254-L268

If this thing works, the third feature can be done. the experience will be better.
Just for some cases the content change or dom change of main content will impact the annotation.

@mobedoor
Copy link
Author

mobedoor commented Sep 6, 2023

Thank you for considering it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants