Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ophidia #136

Open
wants to merge 69 commits into
base: release/2.3.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
e8e42b8
Do not assign default reviewers
orviz Oct 10, 2024
5d6a2f7
Merge pull request #129 from EOSC-synergy/remove_reviewers
orviz Oct 10, 2024
95842fd
Add oclint
orviz Mar 18, 2024
7a47a0d
Fix: C++ key
orviz Mar 19, 2024
b5ab3a0
Enable 'explicit_paths' for oclint
orviz Mar 19, 2024
e3698c8
Merge pull request #128 from EOSC-synergy/release/2.1.0
orviz Oct 10, 2024
e1c0e67
Merge branch 'release/2.1.1' of github.com:eosc-synergy/sqaaas-toolin…
orviz Oct 10, 2024
288991b
Merge pull request #130 from EOSC-synergy/release/2.1.1
orviz Oct 10, 2024
94bc959
Merge pull request #131 from EOSC-synergy/release/2.2.0
orviz Oct 10, 2024
6d0fd4e
Merge pull request #132 from EOSC-synergy/release/2.2.1
orviz Oct 10, 2024
ae65608
Update Dockerfile
micafer Nov 27, 2024
c9d0a3a
Merge pull request #134 from EOSC-synergy/micafer-patch-1
orviz Nov 28, 2024
b8a5cfe
Bumping to FAIR-eva 3.0.3
orviz Dec 10, 2024
fa928bc
Merge pull request #135 from EOSC-synergy/feature/update_fair_eva
orviz Dec 10, 2024
abc6178
Added necessary imports
PalomoIFCA Feb 5, 2025
be1cbc4
changes to dockerfile testing
PalomoIFCA Feb 5, 2025
0be764f
changes to dockerfile testing
PalomoIFCA Feb 5, 2025
bfa07fb
testing installs
PalomoIFCA Feb 5, 2025
992aad4
testing installs
PalomoIFCA Feb 5, 2025
db3ee72
testing installs only one
PalomoIFCA Feb 5, 2025
b58616e
testing installs only one
PalomoIFCA Feb 5, 2025
8269d6e
testing installs only json
PalomoIFCA Feb 5, 2025
a23f58d
testing installs only json
PalomoIFCA Feb 5, 2025
167ad99
testing installs only json
PalomoIFCA Feb 5, 2025
f68f85d
testing only one
PalomoIFCA Feb 5, 2025
935d783
Merge branch 'feature/Ophidia' of https://github.com/EOSC-synergy/sqa…
PalomoIFCA Feb 5, 2025
965e970
echo no import
PalomoIFCA Feb 5, 2025
e87c6aa
import via requirements.txt
PalomoIFCA Feb 6, 2025
d4522c2
just the ccopy
PalomoIFCA Feb 6, 2025
11264cf
first pycodestyle
PalomoIFCA Feb 6, 2025
5ba711f
just pycodedestyle
PalomoIFCA Feb 6, 2025
a2da63b
all without slim
PalomoIFCA Feb 6, 2025
d794e20
all withubuntu/python
PalomoIFCA Feb 6, 2025
1a16e8d
solution1
PalomoIFCA Feb 7, 2025
ed4886c
changed image
PalomoIFCA Feb 10, 2025
db0742c
corrected finder.py
PalomoIFCA Feb 10, 2025
a380ab8
corrected module names
PalomoIFCA Feb 10, 2025
2d9e1d6
corrected module names
PalomoIFCA Feb 10, 2025
511d49a
changed env
PalomoIFCA Feb 10, 2025
9c6fcba
changed last change
PalomoIFCA Feb 10, 2025
f9ba695
changed enviroment
PalomoIFCA Feb 10, 2025
5f37717
changed enviroment
PalomoIFCA Feb 10, 2025
0990a1d
changed requiroments
PalomoIFCA Feb 10, 2025
5fbad3d
changed enviroment
PalomoIFCA Feb 10, 2025
0e872d8
changed requirements
PalomoIFCA Feb 10, 2025
7347e78
mend
PalomoIFCA Feb 10, 2025
25eef27
test print
PalomoIFCA Feb 10, 2025
05934b7
test printtype
PalomoIFCA Feb 10, 2025
250ab5f
especified pyophidia version
PalomoIFCA Feb 10, 2025
d9a1c15
especified pyophidia version from github
PalomoIFCA Feb 10, 2025
5e41814
test modules
PalomoIFCA Feb 11, 2025
fa95c8a
discover modules test
PalomoIFCA Feb 11, 2025
36a0bb2
corrected module name test
PalomoIFCA Feb 11, 2025
cde24e2
corrected module name test2
PalomoIFCA Feb 11, 2025
5cfb358
Cleaning for good version
PalomoIFCA Feb 11, 2025
84c8d95
removed prints
PalomoIFCA Feb 11, 2025
a4484f0
changes to tooling.json to generalise
PalomoIFCA Feb 11, 2025
81dcd74
test for complex situations
PalomoIFCA Feb 12, 2025
5903755
testing failed cases
PalomoIFCA Feb 12, 2025
0fb3f27
testing failed cases
PalomoIFCA Feb 12, 2025
1546578
corrected failed caseswq
PalomoIFCA Feb 12, 2025
89fc94f
added explanations for failure
PalomoIFCA Feb 12, 2025
77365a4
fixes for pre-commit
PalomoIFCA Feb 14, 2025
a75a439
testing for new bug
PalomoIFCA Feb 27, 2025
c4bfde5
testing for debug
PalomoIFCA Feb 27, 2025
ba880a3
debug keys()
PalomoIFCA Feb 27, 2025
a3a66d1
testing the error
PalomoIFCA Feb 27, 2025
8e0afb9
test wisvalid2
PalomoIFCA Feb 27, 2025
3a44712
removed prints and changes for style
PalomoIFCA Feb 28, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @orviz @davrodgon @mariojmdavid @dianamariand92 @samuelbernardolip
# * @orviz @davrodgon @mariojmdavid @dianamariand92 @samuelbernardolip
2 changes: 1 addition & 1 deletion QC.FAIR/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ LABEL authors="Pablo Orviz <orviz@ifca.unican.es>, Fernando Aguilar <aguilarf@if

# Deploy FAIR-eva API
WORKDIR /FAIR_eva
RUN git clone https://github.com/EOSC-synergy/FAIR_eva.git -b 2.0.0 .
RUN git clone https://github.com/EOSC-synergy/FAIR_eva.git -b 3.0.3 .
RUN pip3 install -r requirements.txt

# FAIR-eva client
Expand Down
5 changes: 4 additions & 1 deletion QC.Sty/pyophidia/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
FROM python:3-slim
FROM python:3.10

COPY requirements.txt ./
RUN pip install -r requirements.txt

COPY find_oph_workflows.py /usr/bin

Expand Down
26 changes: 20 additions & 6 deletions QC.Sty/pyophidia/find_oph_workflows.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
from PyOphidia import client
import os
#!/usr/bin/env python
from pyophidia import client
import json
import argparse
import urllib
import requests
import os


def find(pattern, path):
Expand All @@ -30,27 +30,41 @@ def evaluate_workflow_path(candidates):
passed = False
passed_list = []
failed_list = []
reasons_list = []
results = {
"result": passed,
"passed_list": passed_list,
"failed_list": failed_list,
"reasons_list": reasons_list,
}
for jsons in candidates:
f = open(str(jsons), "r")
try:
f = open(str(jsons), "r")
data = json.load(f)

res, msg = ophclient.wisvalid2(data)
except:
try:

data = dict(f.read())

data = json.load(f)
res, msg = ophclient.wisvalid(data)
res, msg = ophclient.wisvalid2(data)
except:

res = False
msg = "Not readable workflow"
if res:
passed = True
passed_list.append(jsons)
else:
failed_list.append(jsons)
reasons_list.append(msg)

results = {
"result": passed,
"passed_list": passed_list,
"failed_list": failed_list,
"reasons_list": reasons_list,
}
return results

Expand Down
2 changes: 2 additions & 0 deletions QC.Sty/pyophidia/requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
argparse
PyOphidia @git+https://github.com/OphidiaBigData/PyOphidia@release
2 changes: 1 addition & 1 deletion QC.Sty/staticcheck/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
FROM golang
RUN go install honnef.co/go/tools/cmd/staticcheck@2022.1.3
RUN go install honnef.co/go/tools/cmd/staticcheck@2024.1.1
8 changes: 4 additions & 4 deletions tooling.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@

"Workflow_manager": {
"PyOphidia": {
"docs": "https://pyophidia.readthedocs.io/en/latest/"
,
"docs": "https://pyophidia.readthedocs.io/en/latest/",
"executable" : "find_oph_workflows.py",
"docker": {
"dockerfile": "QC.Sty/Ophidia/Dockerfile",
"reviewed": "2024-10-02"
Expand Down Expand Up @@ -414,9 +414,9 @@
"version": "latest",
"docs": "QC.FAIR/fair-eva.py",
"docker": {
"image": "eoscsynergy/sqaaas-fair_eva:2.0.0",
"image": "eoscsynergy/sqaaas-fair_eva:3.0.3",
"oneshot": false,
"reviewed": "2022-04-05"
"reviewed": "2024-12-10"
},
"args": [
{
Expand Down
Loading