Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove nlev dependence for some namelist defaults #1255

Open
wants to merge 5 commits into
base: cam_development
Choose a base branch
from
Open

remove nlev dependence for some namelist defaults #1255

wants to merge 5 commits into from

Conversation

brian-eaton
Copy link
Collaborator

Resolve #819 - dependance of some namelist default on the number of vertical levels (lev)?

  • There are just two variables other than ncdata that have an nlev attribute. Those entries can be removed because there are no compsets that use them.

@brian-eaton brian-eaton added the BFB bit for bit tag label Feb 11, 2025
@brian-eaton brian-eaton self-assigned this Feb 11, 2025
@cacraigucar cacraigucar requested a review from fvitt February 25, 2025 16:20
fvitt
fvitt approved these changes Feb 25, 2025
View reviewed changes
Copy link

@fvitt fvitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me provided we are not breaking any aux_cam baseline tests.

@brian-eaton
Copy link
Collaborator Author

Hi @fvitt. I did run the regression tests with these changes and there were no baseline diffs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvitt fvitt fvitt approved these changes

Assignees

@brian-eaton brian-eaton

Labels
BFB bit for bit tag
Projects
CAM Development
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brian-eaton @fvitt