-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WACCM7(x) compsets #1262
base: cam_development
Are you sure you want to change the base?
WACCM7(x) compsets #1262
Conversation
modified: bld/config_files/definition.xml modified: cime_config/config_component.xml modified: cime_config/config_compsets.xml
…dx issue modified: bld/build-namelist modified: bld/configure modified: cime_config/config_component.xml modified: cime_config/config_compsets.xml modified: cime_config/config_pes.xml modified: cime_config/testdefs/testlist_cam.xml modified: src/physics/rrtmgp/mcica_subcol_gen.F90
modified: bld/build-namelist modified: bld/config_files/definition.xml modified: bld/configure modified: cime_config/config_component.xml modified: cime_config/config_compsets.xml new file: bld/namelist_files/use_cases/waccm_ma_hist_cam7.xml
modified: bld/namelist_files/namelist_defaults_cam.xml modified: bld/namelist_files/use_cases/waccm_ma_hist_cam7.xml modified: src/physics/cam/gw_common.F90
modified: cime_config/config_component.xml modified: cime_config/config_compsets.xml
modified: bld/build-namelist modified: bld/namelist_files/namelist_defaults_cam.xml modified: bld/namelist_files/use_cases/waccm_ma_hist_cam7.xml modified: bld/namelist_files/use_cases/waccm_sc_hist_cam7.xml
… list modified: cime_config/testdefs/testlist_cam.xml modified: src/physics/cam/gw_common.F90 modified: src/physics/rrtmgp/mcica_subcol_gen.F90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting that CAM70%HT%CSO
would be a waccm configuration, but configure is not setting waccm_phys="1"
for this compset since it uses ghg_mam4
chemistry. Is it correct that FHIST_WAsc
is not a waccm compset?
I would also propose that configure
be responsible for always setting nlev
rather than having just the cam7 settings be made from config_component.xml
. Here is a suggested refactor of the code to set nlev
:
# Number of vertical levels
my $nlev = 0;
# Defaults
if ($phys_pkg eq 'cam7') {
$nlev = 32 # this is for some old cam_dev tests
if ($model_top eq 'lt') {
$nlev = 58
} elsif ($model_top eq 'mt') {
$nlev = 93
} elsif ($model_top eq 'ht') {
$nlev = 135
} elsif ($model_top eq 'xt') {
$nlev = 189
}
}
elsif ($waccmx) {
if ($phys_pkg eq 'cam6') {
$nlev = 130;
} else {
$nlev = 126;
}
}
elsif ($chem_pkg =~ /waccm_/) {
if ($phys_pkg eq 'cam4') {
$nlev = 66;
}
else {
$nlev = 70;
}
}
elsif ($phys_pkg eq 'cam6') {
$nlev = 32;
}
elsif ($phys_pkg eq 'cam5') {
$nlev = 30;
}
elsif ($phys_pkg eq 'cam4') {
$nlev = 26;
}
else {
# Simple models use cam7-lt vertical grid.
$nlev = 58;
}
closes #1248
closes #1261