Replace ncar_pylib because it is deprecated and will disappear soon #1925
Conversation
| # >>> conda activate ctsm_py | ||
| # >>> cd tools/modify_input_files | ||
| # >>> ./fsurdat_modifier islas_examples/modify_fsurdat/fill_indian_ocean/modify_slevis_16pft.cfg | ||
| # 3) Execute those here |
There was a problem hiding this comment.
@ekluzek @billsacks
Running the plan by you before I spend time on it because I think I remember Bill having hesitations about implementing the new commands inside the test:
- I have removed references to python_path.
- I will have the test execute the module load, module unload, py_env_create, and conda activate before running the tool.
There was a problem hiding this comment.
Another way to do it would be to just ensure that python and conda are in the users path. And that the ctsm_py environment is active for conda. This would expect the user to execute those things outside of the system test itself.
There was a problem hiding this comment.
I forget the details, but I remember having issues in the past with loading and unloading python modules from within a system test, since CIME does its own module load of python. It may have been that it worked when running a single system test, but messed things up when running a whole test suite... but again, I forget the details.
There is some additional discussion in #1798.
I guess I'd say go ahead and try it, and as long as it works even when running a whole test suite, then it's fine by me.
There was a problem hiding this comment.
I need to remind myself what @ekluzek had already accomplished in #1798.
@billsacks thanks for the reminder of the existence of #1798!
Description of changes
In
fsurdatmodifyctsm.pyprepare conda environment before running the fsurdat_modifier tool instead of using ncar_pylib.Specific notes
Contributors other than yourself, if any:
@ekluzek
CTSM Issues Fixed (include github issue #):
addresses #1786 (fixes?)
Are answers expected to change (and if so in what way)?
No, and we'll see...
Any User Interface Changes (namelist or namelist defaults changes)?
Not visible to user.
Testing performed, if any:
Goal is for test
FSURDATMODIFYCTSM_D_Mmpi-serial_Ld1.5x5_amazon.I2000Clm50SpRs.cheyenne_intelto continue working without relying on ncar_pylib.