Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub workflows to check black, pylint, git-fleximod #2964

Open
wants to merge 25 commits into
base: b4b-dev
Choose a base branch
from
Open

Add GitHub workflows to check black, pylint, git-fleximod #2964

wants to merge 25 commits into from

Conversation

samsrabin
Copy link
Collaborator

@samsrabin samsrabin commented Feb 14, 2025 •
edited
Loading

Description of changes

  • Adds workflows to test git-fleximod and pylint.
  • Changes black workflow to test multiple Python versions
  • black and pylint workflows only run when relevant files are changed

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed:

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: None needed except what GitHub does.

@samsrabin samsrabin added enhancement new capability or improved behavior of existing capability testing additions or changes to tests test: none No tests required (e.g. tools/contrib) next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Feb 14, 2025
@samsrabin samsrabin self-assigned this Feb 14, 2025
@samsrabin samsrabin changed the base branch from master to b4b-dev February 14, 2025 17:30
samsrabin
samsrabin commented Feb 14, 2025
View reviewed changes
@samsrabin samsrabin requested a review from ekluzek February 14, 2025 18:45
@samsrabin samsrabin changed the title Add GitHub workflows Add GitHub workflows to check black, pylint, git-fleximod Feb 14, 2025
@samsrabin samsrabin linked an issue Feb 14, 2025 that may be closed by this pull request
Add an action to test python code through different python versions #1580
Open
@samsrabin samsrabin force-pushed the add-github-workflows-20250214 branch from 4bbccde to b5752fa Compare February 14, 2025 20:52
@samsrabin samsrabin marked this pull request as draft February 14, 2025 21:15
@samsrabin samsrabin removed the request for review from ekluzek February 14, 2025 21:15
@samsrabin samsrabin force-pushed the add-github-workflows-20250214 branch from ee38886 to c520d31 Compare February 14, 2025 21:17
@samsrabin samsrabin marked this pull request as ready for review February 14, 2025 21:31
@samsrabin samsrabin requested a review from ekluzek February 18, 2025 20:06
@samsrabin samsrabin added the bfb bit-for-bit label Feb 18, 2025
@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Feb 20, 2025
@samsrabin samsrabin added the PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete label Feb 20, 2025
@samsrabin
Copy link
Collaborator Author

@ekluzek Reminding you to review, as discussed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwieder wwieder wwieder left review comments

@ekluzek ekluzek Awaiting requested review from ekluzek

At least 1 approving review is required to merge this pull request.

Assignees

@samsrabin samsrabin

Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete test: none No tests required (e.g. tools/contrib) testing additions or changes to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an action to test python code through different python versions
2 participants
@samsrabin @wwieder