Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Bytnerowicz" the default nfix_method for clm6 #2972

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −7
Draft

Make "Bytnerowicz" the default nfix_method for clm6 #2972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3efd6bc
Make "Bytnerowicz" the default nfix_method for clm6
slevis-lmwg Feb 21, 2025
ccb31c9
New finidat files
slevis-lmwg Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions bld/namelist_files/namelist_defaults_ctsm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,9 +524,9 @@ attributes from the config_cache.xml file (with keys converted to upper-case).
<!-- The default filenames are given relative to the root directory
for the CLM2 data in the CESM distribution -->
<!-- Plant function types (relative to {csmdata}) -->
<paramfile phys="clm6_0" >lnd/clm2/paramdata/ctsm60_params.c241119.nc</paramfile>
<paramfile phys="clm5_0" >lnd/clm2/paramdata/clm50_params.c241119.nc</paramfile>
<paramfile phys="clm4_5" >lnd/clm2/paramdata/clm45_params.c241119.nc</paramfile>
<paramfile phys="clm6_0" >lnd/clm2/paramdata/ctsm60_params_nfix.c241119.nc</paramfile>
<paramfile phys="clm5_0" >lnd/clm2/paramdata/clm50_params_nfix.c241119.nc</paramfile>
<paramfile phys="clm4_5" >lnd/clm2/paramdata/clm45_params_nfix.c241119.nc</paramfile>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wwieder please review this change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to add nfix to the title of the parameter file? This seems unusual to me? Also, do we typically have the same default parameter list for each physics version? This is naive on my part.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @wwieder I'd nix nfix in the name of the file. We make so many changes to paramfiles you can't keep adding the list of new things to the filenames.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, do we typically have the same default parameter list for each physics version? This is naive on my part.

The values of the parameters are different for each physics version. Hence, we need to have a different parameter file for each physics version. In CESM3.0 we are likely to have two parameter files for clm6_0, one for coupled and one for CRUJRA.

Does that answer your question?


<!-- ================================================================== -->
<!-- FATES default parameter file -->
Expand Down Expand Up @@ -1267,7 +1267,7 @@ attributes from the config_cache.xml file (with keys converted to upper-case).
ic_ymd="18500101" sim_year="1850" do_transient_pfts=".false." use_excess_ice=".true."
ic_tod="0" glc_nec="10" use_crop=".true." irrigate=".false."
phys="clm6_0"
>lnd/clm2/initdata_esmf/ctsm5.3/ctsm53n04ctsm52028_f09_g17_BgcCrop_exice_pSASU.clm60.r.0161-01-01.nc
>lnd/clm2/initdata_esmf/ctsm5.3/ctsm53019_f09_BNF_pSASU.clm2.r.0161-01-01-00000.nc
</finidat>
<!-- Corresponding ne30 -->
<finidat hgrid="ne30np4.pg3" mask="tx2_3v2" use_cn=".true." use_cndv=".false." use_fates=".false."
Expand Down Expand Up @@ -1409,7 +1409,7 @@ attributes from the config_cache.xml file (with keys converted to upper-case).
ic_ymd="20000101" sim_year="2000" use_excess_ice=".true."
ic_tod="0" glc_nec="10" use_crop=".true." irrigate=".true."
phys="clm6_0" use_init_interp=".true."
>lnd/clm2/initdata_esmf/ctsm5.3/ctsm53n04ctsm52028_f09_g17_BgcCrop_exice_hist.clm60.r.2000-01-01.nc
>lnd/clm2/initdata_esmf/ctsm5.3/ctsm53019_f09_BNF_hist.clm2.r.2000-01-01-00000.nc
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions regarding the finidat updates:

  1. I updated 1850 and 2000 for f09 only. Should I update ne30 and f19 with the same f09 file or wait until we have spun up ne30 and f19 simulations?
  2. For ic_ymd="19790101" should I go back and generate a 1979 file or not worry about it for now (e.g. because we will generate finidat files again before all is said and done)? Right now the closest restart file we have is 1978 from the new simulation.
  3. Anything I've forgotten?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we'll end up creating ne30 and f19 initial conditions with this file, as Linnia is going to have new suggestions from the PPE soon. Instead, maybe we point to the f09 initial conditions and set init_interp = true for other resolutions?

</finidat>
<finidat hgrid="ne30np4.pg3" maxpft="79" mask="tx2_3v2" use_cn=".true." use_cndv=".false." use_fates=".false."
ic_ymd="20000101" sim_year="2000" use_excess_ice=".true."
Expand Down Expand Up @@ -1894,6 +1894,7 @@ lnd/clm2/surfdata_esmf/NEON/ctsm5.3.0/surfdata_1x1_NEON_TOOL_hist_2000_78pfts_c2
<freelivfix_slope_wet use_fun=".true." use_cn=".true.">0.0006d00</freelivfix_slope_wet>

<nfix_method>Houlton</nfix_method>
<nfix_method phys="clm6_0">Bytnerowicz</nfix_method>

<br_root>0.83d-06</br_root>

Expand Down
5 changes: 4 additions & 1 deletion bld/namelist_files/namelist_definition_ctsm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,8 +389,11 @@ Intercept of free living Nitrogen fixation with zero annual ET
</entry>

<entry id="nfix_method" type="char*25" category="cnfun_inparm"
group="cnfun_inparm" valid_values="Houlton,Bytnerowicz" value="Houlton" >
group="cnfun_inparm" valid_values="Houlton,Bytnerowicz" value="Bytnerowicz" >
Choice of nfix parameterization
Defaults
- clm6_0 Bytnerowicz
- pre-clm6_0 Houlton
</entry>

<entry id="use_undercanopy_stability" type="logical" category="clm_physics"
Expand Down
2 changes: 1 addition & 1 deletion cime_config/testdefs/testmods_dirs/clm/ciso_cwd_hr/user_nl_clm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
paramfile = '$DIN_LOC_ROOT/lnd/clm2/paramdata/ctsm60_ciso_cwd_hr_params.c241119.nc'
paramfile = '$DIN_LOC_ROOT/lnd/clm2/paramdata/ctsm60_ciso_cwd_hr_params_nfix.c241119.nc'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wwieder pls review this change, also. For this one I had to generate the new file, so could you check my work given past snafus that we've had with paramfiles?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, what am I checking for with this file?

hist_fincl1 = 'CWDC_HR','C13_CWDC_HR','C14_CWDC_HR','CWD_HR_L2','CWD_HR_L2_vr','CWD_HR_L3','CWD_HR_L3_vr'