Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RESTART_CHECKSUMS_REQUIRED to False #221

Open
alperaltuntas opened this issue Jan 22, 2025 · 3 comments
Open

Set RESTART_CHECKSUMS_REQUIRED to False #221

alperaltuntas opened this issue Jan 22, 2025 · 3 comments

Comments

@alperaltuntas
Copy link
Member

...unless in TEST or DEBUG mode.

@mnlevy1981, @gustavo-marques what do you think?

@mnlevy1981
Copy link
Collaborator

Is there a good reason to do this? I could see it being a performance gain, but the checksum would only be computed during init so it would be a one-time benefit rather than speeding up every time step.

@alperaltuntas
Copy link
Member Author

The reason is, when RESTART_CHECKSUMS_REQUIRED is set to True, users encounter an error when they change the PE layout in between continuation runs.

@mnlevy1981
Copy link
Collaborator

That makes sense! I'm okay with changing the default, or with updating the documentation [somewhere?] to make sure users know they need to change this variable in user_nl_mom when changing the PE layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants