Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a CI test to check submodule commit hash consistency #227

Closed

Conversation

alperaltuntas
Copy link
Member

Add a test module to check if the MOM6 submodule commit is the same as what's specificed in .gitmodules

…consistent with the submodule hash specification
@alperaltuntas
Copy link
Member Author

@mnlevy1981 Need a few corrections here. Will let you know.

@mnlevy1981
Copy link
Collaborator

It might be easier to mimic ESCOMP/CESM#317 -- use git fleximod to check out all the externals, and then run git diff --exit-code; I guess that will require either adding git fleximod as an external or checking it out as part of the action.

@alperaltuntas
Copy link
Member Author

This PR is now ready, but happy to close this in favor of ESCOMP/CESM#317

@mnlevy1981
Copy link
Collaborator

I think it makes sense to have a test in MOM_interface even if CESM has a similar test for all components, but this looks like a complicated solution that will only look at MOM6 while git diff --exit-code will also catch issues with inconsistent tags of MARBL and stochastic_physics; the catch is that I don't think we carry git fleximod around in this repo so we'd either need to add it or the github action would need to check it out

@alperaltuntas
Copy link
Member Author

New PR, with no overengineering: #229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants