Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stocks.Prices.get_quote_rh -- Active/after/closed pricing picker #1

Open
3 tasks
lockefox opened this issue Aug 14, 2017 · 0 comments
Open
3 tasks

Comments

@lockefox
Copy link
Contributor

Current code does a crappy job picking the correct current_price value between last_trade_price or last_extended_hours_trade_price.

Also, the current method requires the code to hit /markets and /market/[NAME]/hours/[DATE] every time a quote is requested. Each request can take ~1s, and we already need 3 to make quotes from Robinhood.

  • Improve price picking method (and testability)
  • Add a tinydb, tinymongo or sqlite inline DB for caching today, and throwing away yesterday
  • Enumerate market status (open, after hours, closed, holiday)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant