From ba017dc63f1d6db13a056d257ef0fa04839179a8 Mon Sep 17 00:00:00 2001 From: Axel Huebl Date: Mon, 2 Sep 2024 17:50:42 -0700 Subject: [PATCH] Address two Fixme Comments --- Examples/CMakeLists.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Examples/CMakeLists.txt b/Examples/CMakeLists.txt index 4e366febc06..dc7331a2d7f 100644 --- a/Examples/CMakeLists.txt +++ b/Examples/CMakeLists.txt @@ -117,9 +117,10 @@ function(add_warpx_test ) # set Python executable - set(THIS_Python_EXE) # FIXME unsetting a variable can expose a cache variable that was previously hidden if(python) set(THIS_Python_EXE ${Python_EXECUTABLE}) + else() + set(THIS_Python_EXE "") endif() # test run @@ -172,9 +173,10 @@ function(add_warpx_test # run all tests with 1 OpenMP thread by default set_property(TEST ${name}.run APPEND PROPERTY ENVIRONMENT "OMP_NUM_THREADS=1") - set(THIS_Python_SCRIPT_EXE) # FIXME unsetting a variable can expose a cache variable that was previously hidden if(python OR WIN32) set(THIS_Python_SCRIPT_EXE ${Python_EXECUTABLE}) + else() + set(THIS_Python_SCRIPT_EXE "") endif() # test analysis