Skip to content

Commit 21af699

Browse files
committed
Fix installer missing dlls and not asking for admin
1 parent d1b4d9c commit 21af699

File tree

10 files changed

+17
-3
lines changed

10 files changed

+17
-3
lines changed

application/basilisk/installer/Makefile.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ ifdef MOZ_NO_DEBUG_RTL
6969
ifdef WIN32_REDIST_DIR
7070
DEFINES += -DMOZ_PACKAGE_MSVC_DLLS=1
7171
DEFINES += -DMSVC_C_RUNTIME_DLL=$(MSVC_C_RUNTIME_DLL)
72+
DEFINES += -DMSVC_CMP_RUNTIME_DLL=$(MSVC_CMP_RUNTIME_DLL)
7273
DEFINES += -DMSVC_CXX_RUNTIME_DLL=$(MSVC_CXX_RUNTIME_DLL)
7374
endif
7475
ifdef WIN_UCRT_REDIST_DIR

application/basilisk/installer/package-manifest.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@
100100
@BINPATH@/plugin-hang-ui@BIN_SUFFIX@
101101
#if MOZ_PACKAGE_MSVC_DLLS
102102
@BINPATH@/@MSVC_C_RUNTIME_DLL@
103+
@BINPATH@/@MSVC_CMP_RUNTIME_DLL@
103104
@BINPATH@/@MSVC_CXX_RUNTIME_DLL@
104105
#endif
105106
#if MOZ_PACKAGE_WIN_UCRT_DLLS

application/palemoon/installer/Makefile.in

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,9 @@ DEFINES += -DMOZ_ANGLE_RENDERER=$(MOZ_ANGLE_RENDERER)
6060
ifdef MOZ_D3DCOMPILER_VISTA_DLL
6161
DEFINES += -DMOZ_D3DCOMPILER_VISTA_DLL=$(MOZ_D3DCOMPILER_VISTA_DLL)
6262
endif
63+
ifdef MOZ_D3DCOMPILER_XP_DLL
64+
DEFINES += -DMOZ_D3DCOMPILER_XP_DLL=$(MOZ_D3DCOMPILER_XP_DLL)
65+
endif
6366
endif
6467

6568
DEFINES += -DMOZ_CHILD_PROCESS_NAME=$(MOZ_CHILD_PROCESS_NAME)
@@ -69,6 +72,7 @@ ifdef MOZ_NO_DEBUG_RTL
6972
ifdef WIN32_REDIST_DIR
7073
DEFINES += -DMOZ_PACKAGE_MSVC_DLLS=1
7174
DEFINES += -DMSVC_C_RUNTIME_DLL=$(MSVC_C_RUNTIME_DLL)
75+
DEFINES += -DMSVC_CMP_RUNTIME_DLL=$(MSVC_CMP_RUNTIME_DLL)
7276
DEFINES += -DMSVC_CXX_RUNTIME_DLL=$(MSVC_CXX_RUNTIME_DLL)
7377
endif
7478
ifdef WIN_UCRT_REDIST_DIR

application/palemoon/installer/package-manifest.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@
8484
@BINPATH@/plugin-hang-ui@BIN_SUFFIX@
8585
#if MOZ_PACKAGE_MSVC_DLLS
8686
@BINPATH@/@MSVC_C_RUNTIME_DLL@
87+
@BINPATH@/@MSVC_CMP_RUNTIME_DLL@
8788
@BINPATH@/@MSVC_CXX_RUNTIME_DLL@
8889
#endif
8990
#if MOZ_PACKAGE_WIN_UCRT_DLLS

build/win32/moz.build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ if CONFIG['ENABLE_TESTS']:
1515
NO_PGO = True
1616

1717
if CONFIG['WIN32_REDIST_DIR'] and CONFIG['COMPILE_ENVIRONMENT']:
18-
for f in ['MSVC_C_RUNTIME_DLL', 'MSVC_CXX_RUNTIME_DLL']:
18+
for f in ['MSVC_C_RUNTIME_DLL', 'MSVC_CMP_RUNTIME_DLL', 'MSVC_CXX_RUNTIME_DLL']:
1919
FINAL_TARGET_FILES += [
2020
'%%%s/%s' % (CONFIG['WIN32_REDIST_DIR'], CONFIG[f])
2121
]

js/src/old-configure.in

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,8 @@ case "$target" in
193193
19*)
194194
_CC_SUITE=14
195195
MSVS_VERSION=2015
196-
MSVC_C_RUNTIME_DLL=vcruntime140.dll
196+
MSVC_C_RUNTIME_DLL=vcruntime*.dll
197+
MSVC_CMP_RUNTIME_DLL=vcomp140.dll
197198
MSVC_CXX_RUNTIME_DLL=msvcp140.dll
198199

199200
# C5026: move constructor was implicitly defined as deleted
@@ -212,6 +213,7 @@ case "$target" in
212213
esac
213214
AC_SUBST(MSVS_VERSION)
214215
AC_SUBST(MSVC_C_RUNTIME_DLL)
216+
AC_SUBST(MSVC_CMP_RUNTIME_DLL)
215217
AC_SUBST(MSVC_CXX_RUNTIME_DLL)
216218

217219
# Check linker version

old-configure.in

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,8 @@ case "$target" in
185185
19*)
186186
_CC_SUITE=14
187187
MSVS_VERSION=2015
188-
MSVC_C_RUNTIME_DLL=vcruntime140.dll
188+
MSVC_C_RUNTIME_DLL=vcruntime*.dll
189+
MSVC_CMP_RUNTIME_DLL=vcomp140.dll
189190
MSVC_CXX_RUNTIME_DLL=msvcp140.dll
190191

191192
MOZ_CHECK_HEADER(dia2.h, MSVC_HAS_DIA_SDK=1)
@@ -233,6 +234,7 @@ case "$target" in
233234
AC_SUBST(MSVS_VERSION)
234235
AC_SUBST(MSVC_HAS_DIA_SDK)
235236
AC_SUBST(MSVC_C_RUNTIME_DLL)
237+
AC_SUBST(MSVC_CMP_RUNTIME_DLL)
236238
AC_SUBST(MSVC_CXX_RUNTIME_DLL)
237239

238240
AC_DEFINE(HAVE_SEH_EXCEPTIONS)
0 Bytes
Binary file not shown.

other-licenses/7zstub/uxp/7zSD.sfx

0 Bytes
Binary file not shown.

toolkit/mozapps/installer/upload-files.mk

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,9 @@ endif # MOZ_FOLD_LIBS
7272
ifdef MSVC_C_RUNTIME_DLL
7373
JSSHELL_BINS += $(MSVC_C_RUNTIME_DLL)
7474
endif
75+
ifdef MSVC_CMP_RUNTIME_DLL
76+
JSSHELL_BINS += $(MSVC_CMP_RUNTIME_DLL)
77+
endif
7578
ifdef MSVC_CXX_RUNTIME_DLL
7679
JSSHELL_BINS += $(MSVC_CXX_RUNTIME_DLL)
7780
endif

0 commit comments

Comments
 (0)