Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

added fallback/workaround for unexplained crashes in Firebase console #714

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added fallback/workaround for unexplained crashes in Firebase console #714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/android/GooglePlus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ public class GooglePlus extends CordovaPlugin implements GoogleApiClient.OnConne
public static final String ARGUMENT_SCOPES = "scopes";
public static final String ARGUMENT_OFFLINE_KEY = "offline";
public static final String ARGUMENT_HOSTED_DOMAIN = "hostedDomain";
public static final String ARGUMENT_SAFE_MODE = "safeMode";
public static final String ARGUMENT_CRASH_TEST = "crashTest";

public static final String TAG = "GooglePlugin";
public static final int RC_GOOGLEPLUS = 1552; // Request Code to identify our plugin's activities
Expand All @@ -70,6 +72,9 @@ public class GooglePlus extends CordovaPlugin implements GoogleApiClient.OnConne
private GoogleApiClient mGoogleApiClient;
private CallbackContext savedCallbackContext;

private boolean safeMode = false;
private boolean crashTest = false;

@Override
public void initialize(CordovaInterface cordova, CordovaWebView webView) {
super.initialize(cordova, webView);
Expand Down Expand Up @@ -127,6 +132,9 @@ private synchronized void buildGoogleApiClient(JSONObject clientOptions) throws
return;
}

this.safeMode = clientOptions.optBoolean(ARGUMENT_SAFE_MODE, false);
this.crashTest = clientOptions.optBoolean(ARGUMENT_CRASH_TEST, false);

//If options have been passed in, they could be different, so force a rebuild of the client
// disconnect old client iff it exists
if (this.mGoogleApiClient != null) this.mGoogleApiClient.disconnect();
Expand Down Expand Up @@ -318,7 +326,21 @@ public void onActivityResult(int requestCode, final int resultCode, final Intent
* @param signInResult - the GoogleSignInResult object retrieved in the onActivityResult method.
*/
private void handleSignInResult(final GoogleSignInResult signInResult) {

if (this.safeMode) {
// savedCallbackContext was null in multiple crash reports, unable to reproduce, using this as fallback
// handle in cordova app e.g. timeouts
if (savedCallbackContext == null) {
return;
Copy link

@bhaskar-se bhaskar-se Jan 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexp25 understood the concept here, but one thing if you pay attention is that you are returning from this block if savedCallbackContext is null, and there is no callback for error and no other options to let the caller function know that there is an issue.
Am asking this because savedCallbackContext itself is the callback and the method error is getting called in case of any error.
I doubt this can possibly create another issue which may lead to another potential crash?!

}
// use this to test safe mode crash handling
if (this.crashTest) {
return;
}
}

if (this.mGoogleApiClient == null) {
// here savedCallbackContext was null in multiple crash reports, unable to reproduce
savedCallbackContext.error("GoogleApiClient was never initialized");
return;
}
Expand Down