Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): prevent dedicated RGB LEDs flickering #6045

Merged
merged 2 commits into from
Apr 4, 2025
Merged

Conversation

3djc
Copy link
Collaborator

@3djc 3djc commented Apr 1, 2025

Prevent dedicated RGB leds to be accessible to SF and LUA. Based on the solution chosen for yet unreleased radios

Fixes #6041

@3djc 3djc requested a review from gagarinlg April 1, 2025 12:03
@3djc 3djc changed the title fix: prevent allocated RGB leds to be used fix: prevent dedicated RGB leds to be used Apr 1, 2025
@pfeerick pfeerick changed the title fix: prevent dedicated RGB leds to be used fix: prevent dedicated RGB leds flickering Apr 2, 2025
@pfeerick pfeerick added the bug 🪲 Something isn't working label Apr 2, 2025
@pfeerick pfeerick added this to the 2.11 milestone Apr 2, 2025
@pfeerick
Copy link
Member

pfeerick commented Apr 4, 2025

This at least stops the flickering, but at the expense of not being able to control the RGB leds on the customisable switches at all on the GX12... even when they are not in use. This is something that will need to be improved on as we figure out exactly how to allow dual-use/control of them. i.e. if a customisable switch is set to "None", it's corresponding RGB led should be SF/Lua controllable.

@pfeerick pfeerick changed the title fix: prevent dedicated RGB leds flickering fix(radio): prevent dedicated RGB leds flickering Apr 4, 2025
@pfeerick pfeerick changed the title fix(radio): prevent dedicated RGB leds flickering fix(radio): prevent dedicated RGB LEDs flickering Apr 4, 2025
@pfeerick pfeerick merged commit 07ea98d into main Apr 4, 2025
51 checks passed
@pfeerick pfeerick deleted the 3djc/fix-rgbleds branch April 4, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GX12 RGB LED flashing/blinking/strobing
2 participants