Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAF masking #133

Merged
merged 8 commits into from
May 26, 2024
Merged

VAF masking #133

merged 8 commits into from
May 26, 2024

Conversation

dngoldberg
Copy link
Collaborator

@dngoldberg dngoldberg commented May 17, 2024

This P/R introduces a way to mask the VAF calculation done in solver.comp_Q_vaf() by introducing a logical mask.

The mask (variable vaf_mask) can be applied by setting:

  • params.error_prop.qoi_apply_vaf_mask = True
  • params.io.vaf_mask_data_file to a netcdf file

the netcdf file must have x and y coordinates and the mask variable should be zero where the VAF should not be calculated and greater than zero (e.g. 1) where VAF is to be calculated, and should have a variable name given by params.io.vaf_mask_field_name (default "vaf_mask")

@dngoldberg dngoldberg marked this pull request as ready for review May 22, 2024 13:11
Copy link
Collaborator

@jrmaddison jrmaddison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, better to indent with 4 spaces. I'd prefer setting var_mask to None rather than reading params, but I see this pattern is consistent with other code.

@dngoldberg dngoldberg merged commit 27090ed into EdiGlacUQ:main May 26, 2024
1 check passed
@dngoldberg dngoldberg deleted the branch_vaf_mask branch May 26, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants