Skip to content

Commit

Permalink
Install all package deps on Noble containers (#426)
Browse files Browse the repository at this point in the history
### Proposed changes

Follow-up to #378. Not all package dependencies were brought in by
`rosdep install`. This patch amends that.

#### Type of change

- [x] 🐛 Bugfix (change which fixes an issue)
- [ ] 🚀 Feature (change which adds functionality)
- [ ] 📚 Documentation (change which fixes or extends documentation)

### Checklist

- [x] Lint and unit tests (if any) pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have added necessary documentation (if appropriate)
- [x] All commits have been signed for
[DCO](https://developercertificate.org/)

---------

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
  • Loading branch information
hidmic authored Aug 13, 2024
1 parent 669662e commit d23d446
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion docker/images/jazzy/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ RUN apt-get update \
&& apt-get -y dist-upgrade \
&& . /opt/ros/jazzy/setup.sh \
&& rosdep update \
&& rosdep install -i -y --from-path src --skip-keys 'turtlebot3_gazebo gazebo_ros_pkgs slam_toolbox nav2_amcl nav2_lifecycle_manager nav2_map_server' -t doc -t exec -t build \
&& rosdep install -i -y --from-path src \
&& rosdep install -i -y --from-path src -t doc \
&& sudo rm -rf /var/lib/apt/lists/*

COPY --from=cacher --chown=$USER:$GROUP /ws/ $USER_WS/
Expand Down
3 changes: 2 additions & 1 deletion docker/images/rolling/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ RUN apt-get update \
&& apt-get -y dist-upgrade \
&& . /opt/ros/rolling/setup.sh \
&& rosdep update \
&& rosdep install -i -y --from-path src --skip-keys 'turtlebot3_gazebo gazebo_ros_pkgs slam_toolbox' -t exec -t doc -t build \
&& rosdep install -i -y --from-path src --skip-keys 'slam_toolbox' \
&& rosdep install -i -y --from-path src -t doc \
&& rm -rf /var/lib/apt/lists/*

USER $USER:$GROUP
Expand Down

0 comments on commit d23d446

Please sign in to comment.