From d23d4461bfae2159d6e7e74c7651b7af92562ebc Mon Sep 17 00:00:00 2001 From: Michel Hidalgo Date: Tue, 13 Aug 2024 15:57:45 -0300 Subject: [PATCH] Install all package deps on Noble containers (#426) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### Proposed changes Follow-up to #378. Not all package dependencies were brought in by `rosdep install`. This patch amends that. #### Type of change - [x] 🐛 Bugfix (change which fixes an issue) - [ ] 🚀 Feature (change which adds functionality) - [ ] 📚 Documentation (change which fixes or extends documentation) ### Checklist - [x] Lint and unit tests (if any) pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) - [x] All commits have been signed for [DCO](https://developercertificate.org/) --------- Signed-off-by: Michel Hidalgo --- docker/images/jazzy/Dockerfile | 3 ++- docker/images/rolling/Dockerfile | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docker/images/jazzy/Dockerfile b/docker/images/jazzy/Dockerfile index 37706055b..1e55fceda 100644 --- a/docker/images/jazzy/Dockerfile +++ b/docker/images/jazzy/Dockerfile @@ -106,7 +106,8 @@ RUN apt-get update \ && apt-get -y dist-upgrade \ && . /opt/ros/jazzy/setup.sh \ && rosdep update \ - && rosdep install -i -y --from-path src --skip-keys 'turtlebot3_gazebo gazebo_ros_pkgs slam_toolbox nav2_amcl nav2_lifecycle_manager nav2_map_server' -t doc -t exec -t build \ + && rosdep install -i -y --from-path src \ + && rosdep install -i -y --from-path src -t doc \ && sudo rm -rf /var/lib/apt/lists/* COPY --from=cacher --chown=$USER:$GROUP /ws/ $USER_WS/ diff --git a/docker/images/rolling/Dockerfile b/docker/images/rolling/Dockerfile index c26a494ad..24a3833c3 100644 --- a/docker/images/rolling/Dockerfile +++ b/docker/images/rolling/Dockerfile @@ -107,7 +107,8 @@ RUN apt-get update \ && apt-get -y dist-upgrade \ && . /opt/ros/rolling/setup.sh \ && rosdep update \ - && rosdep install -i -y --from-path src --skip-keys 'turtlebot3_gazebo gazebo_ros_pkgs slam_toolbox' -t exec -t doc -t build \ + && rosdep install -i -y --from-path src --skip-keys 'slam_toolbox' \ + && rosdep install -i -y --from-path src -t doc \ && rm -rf /var/lib/apt/lists/* USER $USER:$GROUP