-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripts for beluga_tutorial visualizations #387
Conversation
@hidmic @nahueespinosa I don't have much experience with Python, but these two simple scripts represent what we wanted to show. One script automatically advances each time step or simulation cycle ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alondruck First pass! I haven't tried it yet, will do shortly.
@nahueespinosa @hidmic The propagate and reweight stages actually represent the same graph, as both are histograms of the same distribution of the set of particles. Do we need to show the reweight stage in a different way, or is it sufficient for what we expect from the tutorial? |
If we opt for the histogram display, then I think it makes more sense to show only three stages: current, prediction (currently called propagation), and update (reweight + resample). This would match the description on the key concepts page about the two main stages in a particle filter algorithm: prediction and update. |
Signed-off-by: Alon Druck <alon.druck@ekumenlabs.com>
Signed-off-by: Alon Druck <alon.druck@ekumenlabs.com>
Signed-off-by: Alon Druck <alon.druck@ekumenlabs.com>
Signed-off-by: Alon Druck <alon.druck@ekumenlabs.com>
05434d0
to
0f66aea
Compare
Signed-off-by: Alon Druck <alon.druck@ekumenlabs.com>
Signed-off-by: Alon Druck <alon.druck@ekumenlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Related to #305, split from #340.
Type of change
Checklist
Put an
x
in the boxes that apply. This is simply a reminder of what we will require before merging your code.