Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add particle filtering tutorial suggestions #407

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Add particle filtering tutorial suggestions #407

merged 7 commits into from
Jul 5, 2024

Conversation

hidmic
Copy link
Collaborator

@hidmic hidmic commented Jul 2, 2024

Proposed changes

Depends on #406. These are suggestions to the writing in #365.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

@Alondruck feel free to take the fragments you like and to drop the ones you don't.

@hidmic
Add particle filtering tutorial suggestions
b423273 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from Alondruck July 2, 2024 13:17
@hidmic hidmic self-assigned this Jul 2, 2024
Alondruck
Alondruck reviewed Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@Alondruck Alondruck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very experienced in doing reviews, especially using GitHub, so if you don't understand any review I made, please let me know!

Overall, I see a significant improvement in the writing of the tutorial! 👏🏽

Alondruck
Alondruck requested changes Jul 5, 2024
View reviewed changes
hidmic and others added 6 commits July 5, 2024 10:49
@hidmic @Alondruck
Update docs/tutorials/particle-filtering.md
9faed03 
Co-authored-by: Alon Druck <44757262+Alondruck@users.noreply.github.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @Alondruck
Update docs/tutorials/particle-filtering.md
815a5d4 
Co-authored-by: Alon Druck <44757262+Alondruck@users.noreply.github.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @Alondruck
Update docs/tutorials/particle-filtering.md
b95e086 
Co-authored-by: Alon Druck <44757262+Alondruck@users.noreply.github.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @Alondruck
Update docs/tutorials/particle-filtering.md
9ceb27a 
Co-authored-by: Alon Druck <44757262+Alondruck@users.noreply.github.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @Alondruck
Update docs/tutorials/particle-filtering.md
347c8bd 
Co-authored-by: Alon Druck <44757262+Alondruck@users.noreply.github.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic @Alondruck
Update docs/tutorials/particle-filtering.md
5d45a27 
Co-authored-by: Alon Druck <44757262+Alondruck@users.noreply.github.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from Alondruck July 5, 2024 13:50
@hidmic
Copy link
Collaborator Author

hidmic commented Jul 5, 2024

@Alondruck all suggestions accepted!

Alondruck
Alondruck approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@Alondruck Alondruck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alondruck Alondruck merged commit c96de8b into alon/mcl_tutorial_doc Jul 5, 2024
@Alondruck Alondruck deleted the hidmic/alon/mcl_tutorial_doc-suggestions branch July 5, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alondruck Alondruck Alondruck approved these changes

Assignees

@hidmic hidmic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hidmic @Alondruck