Rewrite normalize action #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahueespinosa
force-pushed
the
nahuel/rewrite-normalize-action
branch
3 times, most recently
from
91f68ea to
07f612d
Compare
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
nahueespinosa
force-pushed
the
nahuel/rewrite-normalize-action
branch
from
07f612d to
7e56968
Compare
hidmic
reviewed
Oct 7, 2024
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
nahueespinosa
force-pushed
the
nahuel/rewrite-normalize-action
branch
from
d5b93c5 to
185f744
Compare
Fixed in 185f744. |
DPR00
reviewed
Oct 8, 2024
hidmic
approved these changes
Oct 8, 2024
@DPR00 Yeah, that would be great! |
nahueespinosa
pushed a commit
that referenced
this pull request
Oct 16, 2024
### Proposed changes Rewrite overlay function following the guidelines in #441. #### Type of change - [ ] 🐛 Bugfix (change which fixes an issue) - [x] 🚀 Feature (change which adds functionality) - [ ] 📚 Documentation (change which fixes or extends documentation) ### Checklist - [x] Lint and unit tests (if any) pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) - [x] All commits have been signed for [DCO](https://developercertificate.org/) --------- Signed-off-by: Diego Palma <dpalma@symbotic.com> Co-authored-by: Diego Palma <dpalma@symbotic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Trying a new way of implementing actions that gets rid of the argument re-ordering madness and is hopefully easier to maintain.
Type of change
Checklist