-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure and document OpenVDB support #475
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Pablo Vela <pablovela@naver.com>
Signed-off-by: Pablo Vela <pablovela@naver.com>
Signed-off-by: Pablo Vela <pablovela@naver.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass. CC @glpuga too.
Signed-off-by: Pablo Vela <pablovela@naver.com>
Signed-off-by: Pablo Vela <pablovela@naver.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
DEVELOPING.md
Outdated
@@ -66,6 +66,10 @@ Within a development environment: | |||
rosdep install --from-path src | |||
``` | |||
|
|||
|
|||
> [!IMPORTANT] | |||
> `beluga_vdb` requires OpenVDB to be installed in order to be used. For Ubuntu distributions previous to `Noble` OpenVDB needs to be installed from sources before building. Installation instructions can be found [here](beluga_vdb/README.md). If you don't need `beluga_vdb`, you can skip it using `colcon build --symlink-install --packages-ignore beluga_vdb` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvela2017 nit:
> `beluga_vdb` requires OpenVDB to be installed in order to be used. For Ubuntu distributions previous to `Noble` OpenVDB needs to be installed from sources before building. Installation instructions can be found [here](beluga_vdb/README.md). If you don't need `beluga_vdb`, you can skip it using `colcon build --symlink-install --packages-ignore beluga_vdb` | |
> `beluga_vdb` requires OpenVDB to be installed in order to be used. For Ubuntu distributions previous to `Noble` OpenVDB needs to be installed from sources before building. Installation instructions can be found [here](beluga_vdb/README.md). If you don't need `beluga_vdb`, you can skip it using `colcon build --symlink-install --packages-ignore beluga_vdb`. |
Signed-off-by: Pablo Vela <pablovela@naver.com>
Signed-off-by: Pablo Vela <pablovela@naver.com>
Signed-off-by: Pablo Vela <pablovela@naver.com>
Signed-off-by: Pablo Vela <pablovela@naver.com>
Signed-off-by: Pablo Vela <pablovela@naver.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed changes
Fix to issue #474 .
Type of change
Checklist
Put an
x
in the boxes that apply. This is simply a reminder of what we will require before merging your code.