Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure and document OpenVDB support #475

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

pvela2017
Copy link
Contributor

Proposed changes

Fix to issue #474 .

  • Add OpenVDB installation instructions.
  • Install OpenVDB on Humble image.
  • Add note on Developping file.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Signed-off-by: Pablo Vela <pablovela@naver.com>
Signed-off-by: Pablo Vela <pablovela@naver.com>
Signed-off-by: Pablo Vela <pablovela@naver.com>
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass. CC @glpuga too.

Signed-off-by: Pablo Vela <pablovela@naver.com>
Signed-off-by: Pablo Vela <pablovela@naver.com>
@pvela2017 pvela2017 requested a review from hidmic February 27, 2025 04:52
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

DEVELOPING.md Outdated
@@ -66,6 +66,10 @@ Within a development environment:
rosdep install --from-path src
```


> [!IMPORTANT]
> `beluga_vdb` requires OpenVDB to be installed in order to be used. For Ubuntu distributions previous to `Noble` OpenVDB needs to be installed from sources before building. Installation instructions can be found [here](beluga_vdb/README.md). If you don't need `beluga_vdb`, you can skip it using `colcon build --symlink-install --packages-ignore beluga_vdb`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvela2017 nit:

Suggested change
> `beluga_vdb` requires OpenVDB to be installed in order to be used. For Ubuntu distributions previous to `Noble` OpenVDB needs to be installed from sources before building. Installation instructions can be found [here](beluga_vdb/README.md). If you don't need `beluga_vdb`, you can skip it using `colcon build --symlink-install --packages-ignore beluga_vdb`
> `beluga_vdb` requires OpenVDB to be installed in order to be used. For Ubuntu distributions previous to `Noble` OpenVDB needs to be installed from sources before building. Installation instructions can be found [here](beluga_vdb/README.md). If you don't need `beluga_vdb`, you can skip it using `colcon build --symlink-install --packages-ignore beluga_vdb`.

Signed-off-by: Pablo Vela <pablovela@naver.com>
Signed-off-by: Pablo Vela <pablovela@naver.com>
Signed-off-by: Pablo Vela <pablovela@naver.com>
Signed-off-by: Pablo Vela <pablovela@naver.com>
Signed-off-by: Pablo Vela <pablovela@naver.com>
@pvela2017 pvela2017 requested a review from hidmic March 1, 2025 08:20
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with these changes.

Tagging @glpuga as he opened #474 first.

@hidmic hidmic changed the title Add openvdb to humble Ensure and document OpenVDB support Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants