Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

likelihoob prob model sensor #476

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

fbattocchia
Copy link
Collaborator

Proposed changes

The LikelihoodFieldProb sensor model is incorporated, based on the implementation presented in the book Probabilistic Robotics. To achieve this, the LikelihoodFieldModelCommon class is created, which implements the Likelihood Field shared by both the LikelihoodFieldProb and LikelihoodField models.

The LikelihoodFieldProb model, in addition to following the book's implementation, includes the summation of the logarithm of probabilities to prevent underflow when multiplying numerous small probabilities. Additionally, the Cluster-Based Estimation algorithm is integrated, enhancing the model's robustness against unmapped objects.

Furthermore, unit tests are implemented for the LikelihoodFieldProb sensor model.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@fbattocchia fbattocchia force-pushed the fbattocchia_likelihoob_prob branch from 5b73384 to 6404fb2 Compare February 26, 2025 14:27
@fbattocchia fbattocchia requested a review from glpuga February 26, 2025 14:33
@fbattocchia fbattocchia force-pushed the fbattocchia_likelihoob_prob branch from 97474dc to 35c0716 Compare February 26, 2025 15:46
Signed-off-by: fbattocchia <florencia.battocchia@creativa77.com.ar>
@fbattocchia fbattocchia force-pushed the fbattocchia_likelihoob_prob branch from 35c0716 to b8b20cb Compare February 26, 2025 16:07
Signed-off-by: fbattocchia <florencia.battocchia@creativa77.com.ar>
@glpuga glpuga self-assigned this Feb 27, 2025
Signed-off-by: fbattocchia <florencia.battocchia@creativa77.com.ar>
@glpuga
Copy link
Collaborator

glpuga commented Feb 28, 2025

This is currently being evaluated by running Ekumen-OS/lambkin#123 on the whole set of datasets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants