Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pydantic model comparision to use pytest dict diff. #16

Open
jasongilman opened this issue Feb 17, 2025 · 0 comments
Open

Update pydantic model comparision to use pytest dict diff. #16

jasongilman opened this issue Feb 17, 2025 · 0 comments

Comments

@jasongilman
Copy link
Member

@AdeelH noted that the built in dictionary comparison of pytest for pydantic objects would work better than that current JSON string comparison. See this comment #15 (comment)

Ideally the fix for this solution will allow direct comparison of pydantic objects but the diff would use the dictionary comparison from pytest. The change would be made to this file https://github.com/Element84/e84-geoai-common/blob/main/src/e84_geoai_common/llm/tests/pydantic_compare.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant