-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: migrate protoc to buf #350
Conversation
Thank you! Up to now, we’ve been able to generate the proto files with the following commands: cd peerswaprpc
make all-rpc-docker For this PR, how do you plan to generate the proto files? If possible, it would be great if you could add instructions to the documentation. From what I’ve observed, the build failure appears to be due to a mismatch between the version of the generated gRPC code and the gRPC library we’re using. I see two potential approaches to address this: Approach 1: Update the library versionsUpdating the Go dependencies (e.g. google.golang.org/grpc) to v1.64.0 or later should align with the generated code, thus resolving the error. Approach 2: Pin the version to match the existing environmentThis involves fixing the version of the buf plugin. By using the existing |
@YusukeShimizu I want to run build tests in GitHub Actions. Do I need to wait until it runs automatically or is there any other way to run it? I’m not yet familiar with the rules of this project, so I apologize for asking so many beginner questions. I don’t mean to cause trouble, but I would greatly appreciate your response. |
In this repository, It appears that the action was not triggered for commit 0bd9afa . The cause is unclear, but could you please resolve the conflicts and push again? |
@YusukeShimizu Thank you for your understanding. Please let me know if there’s anything else I should address. |
Thank you for not only migrating to buf but also thoughtfully considering the .devcontainer setup. In the future, if we can incorporate buf into ‘nix develop’ and reduce our reliance on Docker, we can further lower the barrier to setting things up. |
This change is an update to the development experience and is not expected to affect the behavior, so I will merge it. |
Issue number: resolves #343
What is the current behavior?
What is the new behavior?
Other information