Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 Rework current pure html to Angular syntax. #65

Merged
merged 15 commits into from
Feb 7, 2025
Merged

#3 Rework current pure html to Angular syntax. #65

merged 15 commits into from
Feb 7, 2025

Conversation

VW03
Copy link
Collaborator

@VW03 VW03 commented Feb 7, 2025

🤍🩵💜MERGEREQUEST💜🩵🤍

📘Table of Contents

  1. 📘Table of Contents
  2. 🖖Introduction
  3. 📎Definition of done Merge Request checklist.

🖖Introduction

This is a Merge Request that is in need of your attention. The person whe created this request is the assignee.

📎Definition of done Merge Request checklist.

  • Tests written (1 positive and 1 negative scenario if possible).

Code architecture

  • Separate services (SRP).
  • Divide functions into functions with low complexity

Code Quality

  • Everything runs.
  • Comments and unused code gone.
  • Correct error handling.

@EliasDeHondt EliasDeHondt added the Closed The issue or task has been completed or resolved. label Feb 7, 2025
@EliasDeHondt EliasDeHondt merged commit 78a73e1 into main Feb 7, 2025
4 checks passed
@EliasDeHondt EliasDeHondt self-requested a review February 7, 2025 10:29
@Meastro85 Meastro85 deleted the #3 branch February 19, 2025 19:10
@EliasDeHondt EliasDeHondt added this to the v1.0.0 milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed The issue or task has been completed or resolved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants