Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websockets #96

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Websockets #96

merged 3 commits into from
Feb 27, 2025

Conversation

Meastro85
Copy link
Collaborator

@Meastro85 Meastro85 commented Feb 27, 2025 •
edited by EliasDeHondt
Loading

🤍🩵💜MERGEREQUEST💜🩵🤍

📘Table of Contents

  1. 📘Table of Contents
  2. 🖖Introduction
  3. 📎Definition of done Merge Request checklist.

🖖Introduction

This is a Merge Request that is in need of your attention. The person who created this request is the assignee.

📎Definition of done Merge Request checklist.

  • Tests written (1 positive and 1 negative scenario if possible).

Code architecture

  • Separate services (SRP).
  • Divide functions into functions with low complexity

Code Quality

  • Everything runs.
  • Comments and unused code gone.
  • Correct error handling.

@EliasDeHondt EliasDeHondt added the In Progress Work on this issue or task is currently ongoing. label Feb 27, 2025
@EliasDeHondt EliasDeHondt added this to the v1.0.0 milestone Feb 27, 2025
@EliasDeHondt EliasDeHondt added Closed The issue or task has been completed or resolved. and removed In Progress Work on this issue or task is currently ongoing. labels Feb 27, 2025
@Meastro85
Merge branch 'main' of https://github.com/EliasDeHondt/K10s into webs…
e19a684 
…ockets

# Conflicts:
#	App/Backend/cmd/main.go
#	App/Frontend/src/app/dashboard/dashboard.component.html
#	App/Frontend/src/app/dashboard/dashboard.component.ts
@EliasDeHondt EliasDeHondt merged commit 197c6f3 into main Feb 27, 2025
7 checks passed
@EliasDeHondt EliasDeHondt deleted the websockets branch February 27, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Meastro85 Meastro85

Labels
Closed The issue or task has been completed or resolved.
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Meastro85 @EliasDeHondt